WS-NA - Bug Fix - Use correct Tipo Image for in-situ promos (Arabic-only) - #14351
Open
pvaliani wants to merge 1 commit into
Open
WS-NA - Bug Fix - Use correct Tipo Image for in-situ promos (Arabic-only)#14351pvaliani wants to merge 1 commit into
pvaliani wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Uses the Tipo promo image as the holding image for Arabic in-situ media players.
Changes:
- Passes promo image URLs through MediaLoader configuration.
- Overrides Ares holding images and adds regression coverage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
MediaLoader/utils/buildSettings.ts |
Forwards the image override. |
MediaLoader/utils/buildSettings.client.test.ts |
Tests generated holding-image settings. |
MediaLoader/types.ts |
Adds optional override types. |
MediaLoader/index.tsx |
Accepts the override prop. |
MediaLoader/index.test.tsx |
Tests configuration forwarding. |
MediaLoader/configs/aresMedia.ts |
Applies the override to Ares media. |
Curation/HierarchicalGrid/index.tsx |
Supplies the Tipo promo image. |
Curation/HierarchicalGrid/index.test.tsx |
Tests in-situ image forwarding. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Nabeel1276
approved these changes
Aug 28, 2026
Contributor
|
why does this say arabic only in the title? Can't see any code that relates to arabic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before:

After:

Code changes
Testing
Useful Links