Skip to content

WS-NA - Bug Fix - Use correct Tipo Image for in-situ promos (Arabic-only) - #14351

Open
pvaliani wants to merge 1 commit into
latestfrom
WS-NA-bug-fix-for-insitu-holding-promo-image
Open

WS-NA - Bug Fix - Use correct Tipo Image for in-situ promos (Arabic-only)#14351
pvaliani wants to merge 1 commit into
latestfrom
WS-NA-bug-fix-for-insitu-holding-promo-image

Conversation

@pvaliani

@pvaliani pvaliani commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes in-situ players showing the original Ares/Castaway image instead of the editorial promo image
  • Uses the resolved promo image already supplied by the BFF
  • Supports Tipo overriding the Optimo promo image
  • Retains the Ares/Castaway image as a fallback
  • Verified locally with distinct Optimo and Tipo images

Before:
image

After:
image

Code changes

  • List key code changes that have been made.

Testing

  1. List the steps required to test this PR.

Useful Links

@pvaliani pvaliani self-assigned this Aug 28, 2026
@pvaliani
pvaliani requested a balanced review from Copilot August 28, 2026 14:09
@pvaliani
pvaliani marked this pull request as ready for review August 28, 2026 14:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Uses the Tipo promo image as the holding image for Arabic in-situ media players.

Changes:

  • Passes promo image URLs through MediaLoader configuration.
  • Overrides Ares holding images and adds regression coverage.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
MediaLoader/utils/buildSettings.ts Forwards the image override.
MediaLoader/utils/buildSettings.client.test.ts Tests generated holding-image settings.
MediaLoader/types.ts Adds optional override types.
MediaLoader/index.tsx Accepts the override prop.
MediaLoader/index.test.tsx Tests configuration forwarding.
MediaLoader/configs/aresMedia.ts Applies the override to Ares media.
Curation/HierarchicalGrid/index.tsx Supplies the Tipo promo image.
Curation/HierarchicalGrid/index.test.tsx Tests in-situ image forwarding.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/app/components/Curation/HierarchicalGrid/index.tsx
@eagerterrier

Copy link
Copy Markdown
Contributor

why does this say arabic only in the title? Can't see any code that relates to arabic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants