Skip to content

screego: bump to 1.12.6 - #49

Merged
bborbe merged 2 commits into
masterfrom
feat/screego-1.12.6
Oct 2, 2026
Merged

bborbe merged 2 commits into
masterfrom
feat/screego-1.12.6

Conversation

@bborbe

@bborbe bborbe commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Bump the self-hosted Screego image from 1.12.5 to 1.12.6.

Version evidence

Registry query (https://hub.docker.com/v2/repositories/screego/server/tags?page_size=20&ordering=last_updated):

  • pre-bump deployed version: 1.12.5
  • max semver tag: 1.12.6 (last_updated 2026-09-27T11:47:32Z)

Skipped 1 (rolling), unstable, and arch-prefixed tags (amd64-1.12.6, arm64-1.12.6, …).

Change

Three files, one line each — only the first deploys; the other two keep the bundle default and the README example honest:

File Role
nodes/hz.hetzner-1.py authoritative — node metadata, what actually deploys
bundles/screego/metadata.py bundle default ('enabled': False path)
bundles/screego/README.md documentation example

Verification

  • make precommit (→ bw test --ignore-missing-faults) — exit 0, "ready to commit"
  • Post-merge: bw verify hz.hetzner-1 → bw apply hz.hetzner-1 (full apply; bw restarts the service via the unit file's triggers:)
  • Post-deploy: docker ps shows screego/server:1.12.6 + Up; Playwright check of https://screen.benjamin-borbe.de/ asserts the footer version, room creation, and 0 console errors

Why a PR and not a direct push

65 Runbooks/Update Screego.md § Step 3 prescribes a direct push to master for a mechanical tag bump. The Development Guide's doc-only carve-out explicitly excludes "no manifest version bump", so this change needs the PR flow — the runbook line is being corrected separately.

@bborbe
bborbe marked this pull request as ready for review October 2, 2026 11:41

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have all the information needed. Let me compile the review.

PR Review: screego: bump to 1.12.6

Files Changed

  • bundles/screego/README.md — example version updated 1.12.5 → 1.12.6
  • bundles/screego/metadata.py — default version updated 1.12.5 → 1.12.6
  • nodes/hz.hetzner-1.py — deployed version updated 1.12.5 → 1.12.6

Step 3a: LICENSE

LICENSE file exists at repo root.

Step 4: Mechanical Funnel

The pre-computed funnel result shows 0 findings. This is a Python-only change (no Go rules apply), and the changed files are metadata/configuration — the ast-grep YAML rules do not cover this file type.

Manual Review

All three concerns from the plan are addressed:

  1. nodes/hz.hetzner-1.py:45 — screego.version updated 1.12.5 → 1.12.6. The PR description cites Docker Hub evidence for this tag. I cannot independently verify external Docker Hub tags without web access, but the version bump follows the established pattern used consistently for other services in this repo (poste, bind, golang, etc.).

  2. bundles/screego/metadata.py:4 — default version is '1.12.6' ✅ matches nodes/hz.hetzner-1.py:45 which sets 'version': '1.12.6'. No issue found — versions are in sync.

  3. bundles/screego/README.md:14 — example version: '1.12.6' ✅ matches the deployed version in nodes/hz.hetzner-1.py:45. No issue found — README is consistent with deployed config.

Notes

  • This PR contains only a simple version bump in three places — a pure metadata/configuration change with no application logic.
  • The update is consistent: all three files reference 1.12.6.
  • No tests exist for this file type (Python node/bundle configuration), so test coverage gaps finding does not apply — there is nothing to test in the traditional sense.
  • precommit skipped (selector mode) — CI covers lint+test.

Selector mode clean — no adjudication needed.

{
  "verdict": "approve",
  "summary": "Simple consistent version bump of screego from 1.12.5 to 1.12.6 across metadata.py defaults, node config, and README example. All three files are in sync. The PR author's Docker Hub evidence supports the tag validity.",
  "comments": [],
  "concerns_addressed": [
    {
      "concern": "correctness: Verify screego/server:1.12.6 is a valid released tag",
      "disposition": "addressed",
      "detail": "PR description cites Docker Hub evidence. Version bump follows established repo pattern. Cannot verify externally but consistent with prior bumps (e.g. poste 2.5.16→2.5.17-2.0.1)."
    },
    {
      "concern": "correctness: Ensure metadata default version stays in sync with authoritative node file after bump",
      "disposition": "addressed",
      "detail": "Confirmed all three files (metadata.py, hz.hetzner-1.py, README.md) show version 1.12.6 — they are in sync."
    },
    {
      "concern": "correctness: Confirm README example version matches the deployed version",
      "disposition": "addressed",
      "detail": "README.md:14 shows 'version: 1.12.6' which matches hz.hetzner-1.py:45 deployed config."
    }
  ]
}

@bborbe
bborbe merged commit 3f8915d into master Oct 2, 2026
4 checks passed
@bborbe
bborbe deleted the feat/screego-1.12.6 branch October 2, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant