Repository navigation
screego: bump to 1.12.6 - #49
Conversation
There was a problem hiding this comment.
Now I have all the information needed. Let me compile the review.
PR Review: screego: bump to 1.12.6
Files Changed
bundles/screego/README.md— example version updated 1.12.5 → 1.12.6bundles/screego/metadata.py— default version updated 1.12.5 → 1.12.6nodes/hz.hetzner-1.py— deployed version updated 1.12.5 → 1.12.6
Step 3a: LICENSE
LICENSE file exists at repo root.
Step 4: Mechanical Funnel
The pre-computed funnel result shows 0 findings. This is a Python-only change (no Go rules apply), and the changed files are metadata/configuration — the ast-grep YAML rules do not cover this file type.
Manual Review
All three concerns from the plan are addressed:
-
nodes/hz.hetzner-1.py:45—screego.versionupdated1.12.5 → 1.12.6. The PR description cites Docker Hub evidence for this tag. I cannot independently verify external Docker Hub tags without web access, but the version bump follows the established pattern used consistently for other services in this repo (poste, bind, golang, etc.). -
bundles/screego/metadata.py:4— defaultversionis'1.12.6'✅ matchesnodes/hz.hetzner-1.py:45which sets'version': '1.12.6'. No issue found — versions are in sync. -
bundles/screego/README.md:14— exampleversion: '1.12.6'✅ matches the deployed version innodes/hz.hetzner-1.py:45. No issue found — README is consistent with deployed config.
Notes
- This PR contains only a simple version bump in three places — a pure metadata/configuration change with no application logic.
- The update is consistent: all three files reference
1.12.6. - No tests exist for this file type (Python node/bundle configuration), so
test coverage gapsfinding does not apply — there is nothing to test in the traditional sense. precommit skipped (selector mode) — CI covers lint+test.
Selector mode clean — no adjudication needed.
{
"verdict": "approve",
"summary": "Simple consistent version bump of screego from 1.12.5 to 1.12.6 across metadata.py defaults, node config, and README example. All three files are in sync. The PR author's Docker Hub evidence supports the tag validity.",
"comments": [],
"concerns_addressed": [
{
"concern": "correctness: Verify screego/server:1.12.6 is a valid released tag",
"disposition": "addressed",
"detail": "PR description cites Docker Hub evidence. Version bump follows established repo pattern. Cannot verify externally but consistent with prior bumps (e.g. poste 2.5.16→2.5.17-2.0.1)."
},
{
"concern": "correctness: Ensure metadata default version stays in sync with authoritative node file after bump",
"disposition": "addressed",
"detail": "Confirmed all three files (metadata.py, hz.hetzner-1.py, README.md) show version 1.12.6 — they are in sync."
},
{
"concern": "correctness: Confirm README example version matches the deployed version",
"disposition": "addressed",
"detail": "README.md:14 shows 'version: 1.12.6' which matches hz.hetzner-1.py:45 deployed config."
}
]
}
Bump the self-hosted Screego image from
1.12.5to1.12.6.Version evidence
Registry query (
https://hub.docker.com/v2/repositories/screego/server/tags?page_size=20&ordering=last_updated):last_updated2026-09-27T11:47:32Z)Skipped
1(rolling),unstable, and arch-prefixed tags (amd64-1.12.6,arm64-1.12.6, …).Change
Three files, one line each — only the first deploys; the other two keep the bundle default and the README example honest:
nodes/hz.hetzner-1.pybundles/screego/metadata.py'enabled': Falsepath)bundles/screego/README.mdVerification
make precommit(→bw test --ignore-missing-faults) — exit 0, "ready to commit"bw verify hz.hetzner-1→bw apply hz.hetzner-1(full apply; bw restarts the service via the unit file'striggers:)docker psshowsscreego/server:1.12.6+Up; Playwright check of https://screen.benjamin-borbe.de/ asserts the footer version, room creation, and 0 console errorsWhy a PR and not a direct push
65 Runbooks/Update Screego.md§ Step 3 prescribes a direct push tomasterfor a mechanical tag bump. The Development Guide's doc-only carve-out explicitly excludes "no manifest version bump", so this change needs the PR flow — the runbook line is being corrected separately.