PKIX: Fix CertPathValidator parsing of the ISIS-MTT dateOfCertGen extension (in the chain validity model), which was missing the unwrap of the extnValue OCTET STRING. A new ValidityModelTest covers the shell and chain validity models through the provider API.

Author: peterdettman

docs/releasenotes.md

@@ -157,6 +157,7 @@ Date: 2026, TBD
 - Signature.setParameter(...) on the composite ML-DSA services threw NullPointerException when called before initSign / initVerify, the composite counterpart of the base-engine defect fixed for issue #2396. The composite SignatureSpi has its own engineSetParameter, which applies a context by re-initialising the component signatures with the key the Signature holds, and it went straight to that re-initialisation without checking there was a key to re-initialise with - with no key the intent is unknowable, so the null key fell into the signing branch and all thirty-six composite services, plus the generic COMPOSITE service, failed identically. The context may now be set either side of initialisation, as it may be for the base ML-DSA and SLH-DSA services: setting it on a signature that already has a key re-initialises the component signatures at once as before, and setting it beforehand records it to be applied when the key arrives. Three further problems in the same method are fixed with it. A parameter spec that is not one of the provider's own but carries a context - the shape another provider's ML-DSA spec has, which the base engines accept - had the context applied and was then reported as rejected by the same call, so a caller that took the exception at its word went on to produce signatures bound to a context it believed had not been set; such a spec is now simply accepted, and one carrying no context at all is still refused. getParameters() cached the AlgorithmParameters it built and setting a new context did not clear that cache, so getParameters() went on reporting the previous context. And on the generic COMPOSITE service, whose algorithm is not known until the key arrives, a CompositeSignatureSpec set beforehand threw NullPointerException from the absent digest; its choice of pre-hash mode is now recorded and applied at initialisation. Setting a context after initialisation, which is what the existing tests and examples do, produces exactly the signatures it did before (github #2412).
 - The structural check on decoded ASN.1 UTCTime / GeneralizedTime content introduced in 1.85 gave no way through for the zone-less UTCTime "YYMMDDHHMMSS", so a single such field made the structure carrying it unreadable: a CMS SignedData whose signing-time attribute lacked its trailing "Z" - a shape found in signatures in circulation - failed to load through both CMSSignedData and CMSSignedDataParser.getSignerInfos() with "invalid UTCTime format", and nothing else in the message could be examined. The value is not a legal UTCTime, X.680 sec. 47.3 making the zone mandatory, but ASN1UTCTime.getTime() has always carried an explicit branch reading it as GMT, so it does denote a real instant and re-encodes unchanged. Setting the new system/security property org.bouncycastle.asn1.allow_zoneless_utctime (Properties.ASN1_ALLOW_ZONELESS_UTCTIME) to "true" admits it - and admits nothing else: every other malformed value, the zone-less "YYMMDDHHMM" without seconds included, is still rejected with the property set, and GeneralizedTime, whose zone is optional to begin with, is unaffected. The property has to be set for the value to decode at all, generation is unaffected, and the value is still not DER, so writing it through a DEROutputStream is refused when Properties.ASN1_ALLOW_NON_DER_TIME is "false". Separately, CMSSignedDataParser.getSignerInfos() let a SignerInfo that failed to decode escape as an unchecked IllegalStateException; it now reports it as the CMSException the method declares (github #2411).
 - The BCJSSE key managers could not select an SM2 certificate for TLS 1.3. ProvX509KeyManager registers a TLS 1.3 EC public-key filter per named curve, but only for the NIST and Brainpool curves, so a key store entry on the sm2p256v1 curve was never matched against the "EC/sm2p256v1" key type the sm2sig_sm3 signature scheme asks for, and a server configured for the RFC 8998 cipher suites failed the handshake with "found no selectable cipher suite among the 1 offered: [TLS_SM4_GCM_SM3]" despite the provider supporting both suites and holding a usable credential. The filter is now registered for curveSM2 on both the client and the server side. As before, the RFC 8998 profile requires explicit configuration: the curveSM2 named group and the sm2sig_sm3 signature scheme are not enabled by default (github #2416).
+- The BC "PKIX" CertPathValidator in the chain validity model (PKIXExtendedParameters.CHAIN_VALIDITY_MODEL) could not use the ISIS-MTT dateOfCertGen extension. CertPathValidatorUtilities.getValidCertDateFromValidityModel() passed the raw result of X509Certificate.getExtensionValue(), which is the DER encoding of the extnValue OCTET STRING, straight to ASN1GeneralizedTime.getInstance(), so any end-entity certificate carrying the extension failed validation with "Could not validate time of certificate." rather than having its issuer checked at the recorded generation time. The OCTET STRING is now unwrapped first, and the underlying decoding error is chained on the reported exception.
 
 ### 2.1.3 Additional Features and Functionality
 

prov/src/main/java/org/bouncycastle/jce/provider/CertPathValidatorUtilities.java

@@ -1116,16 +1116,18 @@ protected static Date getValidCertDateFromValidityModel(Date validityDate, int v
                 byte[] extBytes = issuedCert.getExtensionValue(ISISMTTObjectIdentifiers.id_isismtt_at_dateOfCertGen.getId());
                 if (extBytes != null)
                 {
-                    dateOfCertgen = ASN1GeneralizedTime.getInstance(ASN1Primitive.fromByteArray(extBytes));
+                    // getExtensionValue returns the DER encoding of the extnValue OCTET STRING
+                    byte[] extValue = ASN1OctetString.getInstance(extBytes).getOctets();
+                    dateOfCertgen = ASN1GeneralizedTime.getInstance(ASN1Primitive.fromByteArray(extValue));
                 }
             }
             catch (IOException e)
             {
-                throw new AnnotatedException("Date of cert gen extension could not be read.");
+                throw new AnnotatedException("Date of cert gen extension could not be read.", e);
             }
             catch (IllegalArgumentException e)
             {
-                throw new AnnotatedException("Date of cert gen extension could not be read.");
+                throw new AnnotatedException("Date of cert gen extension could not be read.", e);
             }
             if (dateOfCertgen != null)
             {

prov/src/main/jdk1.1/org/bouncycastle/jce/provider/CertPathValidatorUtilities.java

@@ -1262,16 +1262,18 @@ protected static Date getValidCertDateFromValidityModel(Date validityDate, int v
                 byte[] extBytes = issuedCert.getExtensionValue(ISISMTTObjectIdentifiers.id_isismtt_at_dateOfCertGen.getId());
                 if (extBytes != null)
                 {
-                    dateOfCertgen = ASN1GeneralizedTime.getInstance(ASN1Primitive.fromByteArray(extBytes));
+                    // getExtensionValue returns the DER encoding of the extnValue OCTET STRING
+                    byte[] extValue = ASN1OctetString.getInstance(extBytes).getOctets();
+                    dateOfCertgen = ASN1GeneralizedTime.getInstance(ASN1Primitive.fromByteArray(extValue));
                 }
             }
             catch (IOException e)
             {
-                throw new AnnotatedException("Date of cert gen extension could not be read.");
+                throw new AnnotatedException("Date of cert gen extension could not be read.", e);
             }
             catch (IllegalArgumentException e)
             {
-                throw new AnnotatedException("Date of cert gen extension could not be read.");
+                throw new AnnotatedException("Date of cert gen extension could not be read.", e);
             }
             if (dateOfCertgen != null)
             {

prov/src/main/jdk1.3/org/bouncycastle/jce/provider/CertPathValidatorUtilities.java

@@ -1131,16 +1131,18 @@ protected static Date getValidCertDateFromValidityModel(Date validityDate, int v
                 byte[] extBytes = issuedCert.getExtensionValue(ISISMTTObjectIdentifiers.id_isismtt_at_dateOfCertGen.getId());
                 if (extBytes != null)
                 {
-                    dateOfCertgen = ASN1GeneralizedTime.getInstance(ASN1Primitive.fromByteArray(extBytes));
+                    // getExtensionValue returns the DER encoding of the extnValue OCTET STRING
+                    byte[] extValue = ASN1OctetString.getInstance(extBytes).getOctets();
+                    dateOfCertgen = ASN1GeneralizedTime.getInstance(ASN1Primitive.fromByteArray(extValue));
                 }
             }
             catch (IOException e)
             {
-                throw new AnnotatedException("Date of cert gen extension could not be read.");
+                throw new AnnotatedException("Date of cert gen extension could not be read.", e);
             }
             catch (IllegalArgumentException e)
             {
-                throw new AnnotatedException("Date of cert gen extension could not be read.");
+                throw new AnnotatedException("Date of cert gen extension could not be read.", e);
             }
             if (dateOfCertgen != null)
             {

prov/src/main/jdk1.4/org/bouncycastle/jce/provider/CertPathValidatorUtilities.java

@@ -1123,16 +1123,18 @@ protected static Date getValidCertDateFromValidityModel(Date validityDate, int v
                 byte[] extBytes = issuedCert.getExtensionValue(ISISMTTObjectIdentifiers.id_isismtt_at_dateOfCertGen.getId());
                 if (extBytes != null)
                 {
-                    dateOfCertgen = ASN1GeneralizedTime.getInstance(ASN1Primitive.fromByteArray(extBytes));
+                    // getExtensionValue returns the DER encoding of the extnValue OCTET STRING
+                    byte[] extValue = ASN1OctetString.getInstance(extBytes).getOctets();
+                    dateOfCertgen = ASN1GeneralizedTime.getInstance(ASN1Primitive.fromByteArray(extValue));
                 }
             }
             catch (IOException e)
             {
-                throw new AnnotatedException("Date of cert gen extension could not be read.");
+                throw new AnnotatedException("Date of cert gen extension could not be read.", e);
             }
             catch (IllegalArgumentException e)
             {
-                throw new AnnotatedException("Date of cert gen extension could not be read.");
+                throw new AnnotatedException("Date of cert gen extension could not be read.", e);
             }
             if (dateOfCertgen != null)
             {

prov/src/test/java/org/bouncycastle/jce/provider/test/RegressionTest.java

@@ -111,6 +111,7 @@ public class RegressionTest
         new SM9SignatureTest(),
         new ThreefishTest(),
         new TLSKDFTest(),
+        new ValidityModelTest(),
         new WrapTest(),
         new X509CertificatePairTest(),
         new X509LDAPCertStoreTest(),

prov/src/test/java/org/bouncycastle/jce/provider/test/TestCertificateGen.java

@@ -109,15 +109,21 @@ public static X509Certificate createCert(X500Name signerName, PrivateKey signerK
     public static X509Certificate createCert(X500Name signerName, PrivateKey signerKey, X500Name dn, String sigName, Extensions extensions, PublicKey pubKey)
         throws Exception
     {
-        V3TBSCertificateGenerator certGen = new V3TBSCertificateGenerator();
-
         long time = System.currentTimeMillis();
 
+        return createCert(signerName, signerKey, dn, sigName, new Date(time - 5000), new Date(time + 30 * 60 * 1000), extensions, pubKey);
+    }
+
+    public static X509Certificate createCert(X500Name signerName, PrivateKey signerKey, X500Name dn, String sigName, Date notBefore, Date notAfter, Extensions extensions, PublicKey pubKey)
+        throws Exception
+    {
+        V3TBSCertificateGenerator certGen = new V3TBSCertificateGenerator();
+
         certGen.setSerialNumber(ASN1Integer.valueOf(getSerialNumber()));
         certGen.setIssuer(signerName);
         certGen.setSubject(dn);
-        certGen.setStartDate(new Time(new Date(time - 5000)));
-        certGen.setEndDate(new Time(new Date(time + 30 * 60 * 1000)));
+        certGen.setStartDate(new Time(notBefore));
+        certGen.setEndDate(new Time(notAfter));
         certGen.setSignature((AlgorithmIdentifier)algIds.get(sigName));
         certGen.setSubjectPublicKeyInfo(SubjectPublicKeyInfo.getInstance(pubKey.getEncoded()));
         certGen.setExtensions(extensions);