Apply pool overflow to the ssl_pooling checkout path - #882
Merged
Conversation
checkout_ssl_fallback still fast-failed with checkout_timeout at max_connections, unlike the plain checkout path fixed in 4.4.1. Make it open an overflow connection too (per-host concurrency stays capped by max_per_host via load regulation); the checkin side already applies the idle-pool cap. Adds a test covering SSL overflow past pool_size.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 4.4.1. The overflow fix landed on the plain TCP checkout (and so on default HTTPS, which checks out a TCP conn then upgrades), but
checkout_ssl_fallback- the opt-inssl_poolingpath - still had the old fast-fail:So
ssl_poolingwith pool_size < max_per_host could still hit the spurious checkout_timeout race. This makes it open an overflow connection like the plain path; per-host concurrency stays capped by max_per_host, and the checkin side already applies the idle-pool cap via pool_has_idle_room/1.HTTP/2 and HTTP/3 are unaffected: they multiplex over shared connections and have no per-checkout max_connections slot.
Adds test_checkout_ssl_overflow (two SSL checkouts at pool_size=1 both succeed with distinct live conns, in_use=2).