Repository navigation
feat: upgrade stable frameworks and migrate AI SDK 7 - #295
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 725e71861a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
olliethedev
left a comment
olliethedev
left a comment
There was a problem hiding this comment.
Independent final-commit review completed on 295823f03dd6dfa1f5b7e72d5403f9eba3c8cae5 against 63f08c6f7566a5d1b5f4e6f7c844981cec022ca9.
Standards
Hard documented-standard violations: 0. Actionable baseline smells: 0. Reviewed production upgrade changes, scaffolds, cohort metadata, migration documentation, registry output, and regression hunks against AGENTS.md, CONTRIBUTING.md, and relevant BTST skills. Framework-specific version declarations follow existing repository boundaries; extra shared abstractions would conflict with the minimum-code and surgical-change rules.
Spec
Findings: 0. No missing requirements, unasked behavior, or concrete implementation errors found against the confirmed stable-framework/AI/Auth scope. Checked retained consumer contracts and primitives, dependency cohorts, generators/playground exports, registry compatibility, SDK7 streaming/compaction, and writable upload routing. The documented Auth pagination and upstream advisory limits remain explicit.
Both reviewers were independent, read-only, and pinned to the final commit. The committed lockfile matches the tested workspace. All 11 CI jobs and both Vercel previews pass; codegen E2E reports 582 passed / 4 conditional skips. The exact-commit release gate also passes.
The hosted Codex request still reports running without a final result after more than 30 minutes. These completed final-head reviews provide the repository-required review while that request remains monitored for late findings. The original lockfile finding is fixed and resolved.
Summary
Update the matching Query, Tailwind, Zod, editor, provider and build dependencies. Preserve existing React 19, Next 15+ and React Router 7 consumer support, shared Radix primitives, current plugin APIs, and durable chat authorization/history. Add the v5 migration guide and stable-framework fixtures. Companion full upstream syncs: better-stack-ai/better-auth#52 and better-stack-ai/better-auth-ui#30.
Evidence
stepCountIsand instance stream-response helpers; tool approval messages and stream completion callbacks have new shapes. The new real-SDK regression reproduces a third tool-step prompt containing only the old summary after compaction.After: Real SDK streaming persists completed assistant messages, preserves configured instructions and rejects caller system/data messages. Reconstructing each step from initial and response messages retains the current question and both tool results across repeated compaction. All 1,171 Stack unit tests pass, including 170 AI tests; all 198 CLI tests pass. Build, public typecheck, lint and Knip pass.
nitro@3.0.260603-beta; current shadcn's Panels wrapper disagrees with the existing UI Builder API.After: Stable srvx serves the standard Vite output and writable uploads; registry generation and all nine plugin installs compile successfully. The matching existing Panels wrapper is embedded.
After: The published cohort passes a clean frozen install from npm, CLI init generation, migration/idempotency checks and production compilation. The committed lockfile uses official registry metadata and excludes generated test-workspace importers. Docs and playground production builds pass. React Router 7 source typecheck passes alongside the Router 8 application matrix.
All 11 CI jobs pass on
295823f0, including 582 browser cases across the three frameworks with 4 conditional skips. All four strict npm/pnpm packed consumers and all three Auth UI framework fixtures pass. Both Vercel previews are READY and the exact-commit release gate passes.Merge Danger
Door: one-way
Source changes can be reverted; published npm versions cannot be replaced. AI Chat requires the new SDK majors and Node 22. Database schema/index changes require application review before migration.
Blast Radius: consumers
Applications using optional AI or Auth integrations must update matching companions. The final audit has zero critical, high or moderate findings. Two low upstream audit findings remain: KaTeX through rehype-katex and deepmerge in build tooling. The Auth fork's session-pagination fix is source-only: official npm Auth 1.7.14 remains affected when secondary storage is combined with database session storage without preservation. The default database session configuration is unaffected; the migration guide records this limit.