Repository navigation
feat: wire School lessons and generated resource discussions - #354
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Bundle size6 of 194 bundles changed.
Measured 22 packed archives separately; full report includes their compressed bytes without installed dependencies. |
Summary
Add the optional School lesson slot without a Comments dependency. Generate selected slots and
comments.resourceLinksfor all three frameworks. School and Kanban helpers retain route context in resource IDs; Kanban?task=links reopen the task dialog. Update docs, E2E overlays, and School/Kanban registry output.Closes #348.
Evidence
schoolName; CLI-generated providers had no automatic comment slots or resource return links.After: scaffold-plan 174 passed, School focused tests 16 passed, independent client runtime tests Blog 6 / Kanban 3 / Comments 6 passed.
git diff --checkpassed. Full local tests and other-framework browser runs were not run; CI owns full coverage.Evidence URLs require the owner's archive login and LAN or private Tailscale access. All seven video frames were inspected against their captions; mobile document width equals the 390px viewport, and keyboard focus reaches Post comment.
Merge Danger
Door: two-way
Optional UI and generated configuration; no schema or dependency changes. Generated School IDs use
<courseSlug>/lessons/<lessonId>, Kanban uses<boardId>/<taskId>; preserve these conventions when customizing, or migrate existing resource IDs. Existing manually configured plain-ID threads remain application-owned.Blast Radius: integrations
School lesson rendering, Kanban task links, and generated providers. Plugins installed individually retain no Comments wiring.