Skip to content

feat: wire School lessons and generated resource discussions - #354

Merged
olliethedev merged 1 commit into
mainfrom
feat/issue-348-after-v6
Nov 6, 2026
Merged

olliethedev merged 1 commit into
mainfrom
feat/issue-348-after-v6

Conversation

@olliethedev

Copy link
Copy Markdown
Collaborator

Summary

comments + blog   → postBottomSlot → CommentThread
comments + kanban → taskDetailBottomSlot → task discussion + return link
comments + school → lessonBottomSlot → lesson discussion + return link

Add the optional School lesson slot without a Comments dependency. Generate selected slots and comments.resourceLinks for all three frameworks. School and Kanban helpers retain route context in resource IDs; Kanban ?task= links reopen the task dialog. Update docs, E2E overlays, and School/Kanban registry output.

Closes #348.

Evidence

  • Before: School exposed only schoolName; CLI-generated providers had no automatic comment slots or resource return links.
    After: scaffold-plan 174 passed, School focused tests 16 passed, independent client runtime tests Blog 6 / Kanban 3 / Comments 6 passed.
  • Browser: 2 Chromium regressions passed: School post/reload/return link; Kanban post/task-dialog return link and unknown task. The generated Next.js app uses the normal E2E auth overlay.
  • Checks: CLI, School, Kanban and generated Next.js typechecks; docs production build; changed-file Biome; registry generation; git diff --check passed. Full local tests and other-framework browser runs were not run; CI owns full coverage.
  • Captioned demo and all eight screenshots · MP4
  • School discussion · Kanban task · All return links · 390px mobile

Evidence URLs require the owner's archive login and LAN or private Tailscale access. All seven video frames were inspected against their captions; mobile document width equals the 390px viewport, and keyboard focus reaches Post comment.

Merge Danger

Door: two-way

Optional UI and generated configuration; no schema or dependency changes. Generated School IDs use <courseSlug>/lessons/<lessonId>, Kanban uses <boardId>/<taskId>; preserve these conventions when customizing, or migrate existing resource IDs. Existing manually configured plain-ID threads remain application-owned.

Blast Radius: integrations

School lesson rendering, Kanban task links, and generated providers. Plugins installed individually retain no Comments wiring.

@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
better-stack-docs Ready Ready Preview Nov 6, 2026 3:44am UTC
better-stack-playground Ready Ready Preview Nov 6, 2026 3:44am UTC

Request Review

@olliethedev

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T03:46:48.573892Z d28a552 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: d28a5521bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Bundle size

6 of 194 bundles changed.

Module Gzip base → PR Gzip change Minified change
@btst/codegen 1636731 → 1637191 B +460 B (+0.0%) +1544 B (+0.0%)
@btst/codegen/lib 50636 → 51058 B +422 B (+0.8%) +1519 B (+0.9%)
@btst/plugin-kanban/client 602783 → 602897 B +114 B (+0.0%) +263 B (+0.0%)
@btst/plugin-kanban/client/components 598944 → 599049 B +105 B (+0.0%) +263 B (+0.0%)
@btst/plugin-school/client/components 192105 → 192128 B +23 B (+0.0%) +34 B (+0.0%)
@btst/plugin-school/client 194744 → 194749 B +5 B (+0.0%) +34 B (+0.0%)

10ef1f7 → d28a552. Standalone costs; rows overlap. Moved paths appear as new/removed entries, not application savings.

Measured 22 packed archives separately; full report includes their compressed bytes without installed dependencies.

Full report and measurements

@olliethedev
olliethedev merged commit ad53b4c into main Nov 6, 2026
62 checks passed

This branch was successfully deployed

2 active deployments
Preview – better-stack-docs — d28a5521 Deployed Nov 6, 2026 by vercel[bot]
Preview – better-stack-playground — d28a5521 Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments: lessonBottomSlot in School and CLI auto-wiring across Blog, Kanban, and School

1 participant