Skip to content

Commit 286c6a6

Browse files
authored
Merge pull request #3181 from Anai-Guo/fix-audit-log-missing-action
fix(server): five audit_log calls omit the required action argument
2 parents cc5b690 + 38bfb98 commit 286c6a6

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

simpletuner/simpletuner_sdk/server/routes/approvals.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,8 @@ async def approve_request(
419419
# Audit log
420420
if request:
421421
await audit_log(
422-
event_type=AuditEventType.JOB_APPROVED,
422+
AuditEventType.JOB_APPROVED,
423+
f"Job {request.job_id} approved by '{user.username}'",
423424
actor_id=user.id,
424425
target_type="approval_request",
425426
target_id=str(request_id),
@@ -484,7 +485,8 @@ async def reject_request(
484485
# Audit log
485486
if request:
486487
await audit_log(
487-
event_type=AuditEventType.JOB_REJECTED,
488+
AuditEventType.JOB_REJECTED,
489+
f"Job {request.job_id} rejected by '{user.username}'",
488490
actor_id=user.id,
489491
target_type="approval_request",
490492
target_id=str(request_id),
@@ -570,7 +572,8 @@ async def bulk_approve_requests(
570572

571573
# Audit log
572574
await audit_log(
573-
event_type=AuditEventType.JOB_APPROVED,
575+
AuditEventType.JOB_APPROVED,
576+
f"Job {request.job_id} approved by '{user.username}' (bulk)",
574577
actor_id=user.id,
575578
target_type="approval_request",
576579
target_id=str(request_id),
@@ -634,7 +637,8 @@ async def bulk_reject_requests(
634637

635638
# Audit log
636639
await audit_log(
637-
event_type=AuditEventType.JOB_REJECTED,
640+
AuditEventType.JOB_REJECTED,
641+
f"Job {request.job_id} rejected by '{user.username}' (bulk)",
638642
actor_id=user.id,
639643
target_type="approval_request",
640644
target_id=str(request_id),

simpletuner/simpletuner_sdk/server/services/cloud/credential_resolver.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ async def get_credential(
124124
from .audit import AuditEventType, audit_log
125125

126126
await audit_log(
127-
event_type=AuditEventType.CREDENTIAL_USED,
127+
AuditEventType.CREDENTIAL_USED,
128+
f"Credential '{provider}/{credential_name}' used",
128129
actor_id=user_id,
129130
target_type="credential",
130131
target_id=f"{provider}/{credential_name}",

0 commit comments

Comments
 (0)