better validation ux for attention mechanism selection - #2455
Merged
Conversation
samzhang996-hue
pushed a commit
to samzhang996-hue/SimpleTuner
that referenced
this pull request
Apr 27, 2026
…ntion-impl better validation ux for attention mechanism selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved validation for attention mechanism selection in both configuration normalization and server-side validation logic. The main focus is to ensure users receive clear error messages when selecting unsupported attention mechanisms, specifically addressing compatibility issues with
xformerson certain GPUs and the availability ofsageattention.Attention mechanism validation improvements:
is_sageattention_availableandxformers_compute_capability_errorhelper functions toattention_backend.pyto check for SageAttention installation and xformers GPU compatibility, respectively._normalize_input_argsincmd_args.pyto raise aValueErrorifxformersis selected on unsupported GPUs, or ifsageattentionis requested but not installed.validation_service.pyto add configuration errors for unsupportedxformersor missingsageattention, improving feedback to users during config validation.Internal API changes:
cmd_args.pyandvalidation_service.pyto enable their use in argument normalization and validation logic. [1] [2]