Gather batch-parallel validation payloads - #3086
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates distributed validation in Validation.process_prompts to gather batch-parallel validation payloads via accelerate.utils.gather_object, aiming to ensure rank 0 receives and persists media payloads (notably audio) produced on peer ranks.
Changes:
- Switched distributed validation payload gathering from the project’s torch-distributed helper to
accelerate.utils.gather_object. - Adjusted aggregation flow to treat gathered payloads as a single ordered collection before applying results on rank 0.
- Added a regression test asserting batch-parallel audio validation includes peer-rank audio payloads in the saved outputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
simpletuner/helpers/training/validation.py |
Replaces cross-process payload gathering implementation used during distributed validation. |
tests/test_validation_context_parallel.py |
Adds regression coverage for gathering and saving audio payloads produced on non-zero ranks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Batch-parallel validation split prompt work with the accelerator, but gathered result payloads through SimpleTuner's torch-distributed helper. In runs where that helper could not see an initialized torch-distributed group, rank 0 only received its own local payload list, so audio samples generated on peer ranks were never added to the saved validation audio set.
Validation
.venv/bin/python -m unittest -v tests.test_validation_context_parallel tests.test_validation_audio_mock tests.test_validation_external