Skip to content

torchcodec + H3 single file fixes - #3135

Merged
bghira merged 3 commits into
mainfrom
codex/torch210-inductor-pass-guard
Aug 22, 2026
Merged

torchcodec + H3 single file fixes#3135
bghira merged 3 commits into
mainfrom
codex/torch210-inductor-pass-guard

Conversation

@bghira

@bghira bghira commented Aug 22, 2026

Copy link
Copy Markdown
Owner

This pull request introduces several improvements and bug fixes across audio loading, model configuration, and TorchInductor training pass handling, along with new and enhanced tests to ensure the reliability of these changes.

Audio Loading Improvements:

  • The load_audio function now attempts to use ffmpeg for all filesystem paths if torchaudio fails, regardless of file extension, improving robustness when TorchCodec is unavailable. Logging for ffmpeg fallback failures is also improved.
  • Added a new test AudioLoadTests.test_filesystem_path_uses_ffmpeg_when_torchaudio_fails to verify that ffmpeg is used as a fallback when torchaudio.load fails.

TorchInductor Training Pass Handling:

  • Updated the dynamic training pass configuration to import the TorchInductor config module more robustly and handle cases where the disabled_passes attribute is missing, with appropriate logging.
  • Added a test to ensure that missing disabled_passes in TorchInductor config is handled gracefully and the environment variable is still set.

Model Configuration Logic:

  • Improved _model_config_path in the MiniMaxH3 model to correctly handle cases where only the transformer path is a single file, ensuring local components are preserved.
  • Added a test to verify that _model_config_path returns the correct path when the transformer is a single file.

@bghira
bghira merged commit bc8e6ab into main Aug 22, 2026
2 checks passed
@bghira
bghira deleted the codex/torch210-inductor-pass-guard branch August 22, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant