torchcodec + H3 single file fixes - #3135
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes across audio loading, model configuration, and TorchInductor training pass handling, along with new and enhanced tests to ensure the reliability of these changes.
Audio Loading Improvements:
load_audiofunction now attempts to use ffmpeg for all filesystem paths iftorchaudiofails, regardless of file extension, improving robustness when TorchCodec is unavailable. Logging for ffmpeg fallback failures is also improved.AudioLoadTests.test_filesystem_path_uses_ffmpeg_when_torchaudio_failsto verify that ffmpeg is used as a fallback whentorchaudio.loadfails.TorchInductor Training Pass Handling:
disabled_passesattribute is missing, with appropriate logging.disabled_passesin TorchInductor config is handled gracefully and the environment variable is still set.Model Configuration Logic:
_model_config_pathin the MiniMaxH3 model to correctly handle cases where only the transformer path is a single file, ensuring local components are preserved._model_config_pathreturns the correct path when the transformer is a single file.