Remove Diffusers group offload integration - #3150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
SimpleTuner already has weight-streaming implementations with explicit training lifecycle, adapter-residency, quantization, and distributed handling. The Diffusers group-offload path duplicated that responsibility through pipeline hooks and required model-family exceptions throughout otherwise generic loading and validation code. Removing it eliminates the overlapping state machine and its configuration surface.
Validation
.venv/bin/python -m unittest -v tests.test_group_offload_removed tests.test_krea2_model tests.test_ramtorch tests.test_quanto_workarounds tests.test_model_field_registry tests.test_config_field_validationnpm test -- --runInBand tests/js/training_wizard.test.js