Skip to content

Prevent training service tests from leaking running jobs - #3174

Merged
bghira merged 1 commit into
mainfrom
bugfix/local-job-test-isolation
Aug 31, 2026
Merged

Prevent training service tests from leaking running jobs#3174
bghira merged 1 commit into
mainfrom
bugfix/local-job-test-isolation

Conversation

@bghira

@bghira bghira commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • isolate training service unit tests from the persistent job repository so mocked start_training_job calls do not leave local jobs running
  • reconcile all running local jobs by default on startup, retaining the optional cap for explicit callers
  • add regression coverage for more than the old startup reconciliation cap

Validation

  • .venv/bin/python -m unittest tests.test_training_service tests.test_local_gpu_allocator -v -f
  • SIMPLETUNER_SELENIUM_TESTS=1 SELENIUM_SERVER_START_TIMEOUT=180 .venv/bin/python -m unittest tests.test_webui_e2e.TrainingMetricsDashboardTestCase.test_training_run_metrics_and_validation_media -v -f
  • .venv/bin/python -m py_compile tests/test_training_service.py tests/test_local_gpu_allocator.py simpletuner/simpletuner_sdk/server/services/local_gpu_allocator.py
  • git diff --check

@bghira
bghira merged commit 9977d24 into main Aug 31, 2026
2 checks passed
@bghira
bghira deleted the bugfix/local-job-test-isolation branch August 31, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant