Skip to content

Fix validation lightbox checkpoint switching - #3189

Merged
bghira merged 1 commit into
mainfrom
fix/3188-lightbox-step-gallery
Aug 31, 2026
Merged

Fix validation lightbox checkpoint switching#3189
bghira merged 1 commit into
mainfrom
fix/3188-lightbox-step-gallery

Conversation

@bghira

@bghira bghira commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep validation lightbox checkpoint navigation scoped to the open image
  • prevent modal step changes from re-rendering the background validation gallery
  • cover the behavior in JS unit tests and Selenium E2E test

Fixes #3188

Tests

  • npm test -- training_metrics_component.test.js
  • SIMPLETUNER_SELENIUM_TESTS=1 .venv/bin/python -m unittest tests.test_webui_e2e.TrainingMetricsDashboardTestCase.test_training_run_metrics_and_validation_media -v

@bghira
bghira merged commit 5692bae into main Aug 31, 2026
2 checks passed
@bghira
bghira deleted the fix/3188-lightbox-step-gallery branch August 31, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lightbox step change is very slow

1 participant