Feat/audit remediation and expert tier - #31
Merged
Conversation
…aware
Two problems, one of which was blocking the build outright.
1. SCHEMA VALIDATION FAILURE
Both vercel.json files used `"//"` keys as pseudo-comments. JSON has no
comment syntax and Vercel's schema forbids unknown properties, so the
deploy failed before it started:
The `vercel.json` schema validation failed with the following message:
should NOT have additional property `//`
All `//`, `//commands` and `//ignoreCommand` keys are gone. The rationale
they carried now lives in docs/runbooks/deployment-prerequisites.md, which
can hold prose properly.
2. COMMANDS WERE STALE AFTER REF-01
The root file ran `npm --prefix client ci`, which needs
client/package-lock.json — deleted when the repo became an npm workspace.
It also never built @dwcode/shared, so the build would have failed on a
missing module even after the install was fixed.
Root (Root Directory = repo root):
install npm ci
build npm run build:shared && npm run build:client
output client/.next
client/ (Root Directory = client):
install npm ci --prefix ..
build npm run build:shared --prefix .. && npm run build
Both are now correct, so either Root Directory setting works.
ignoreCommand also widened: a change to packages/ or the root lockfile
must trigger a frontend build, and previously would not have.
Verified by running the root buildCommand end to end: build:shared and
build:client both succeed and client/.next is produced.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Also documents that Root Directory = repo root is now the simpler option: with the workspace root as the build context, packages/shared is already in scope, so the dashboard-only 'Include source files outside of the Root Directory' toggle is no longer needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.