Repository navigation
Conversation
Contributor
|
Warning: this PR is likely to conflict with PR #4092 |
jay23606
force-pushed
the
fix-hx-head-pending-resource-race
branch
from
October 16, 2026 20:15
68c29e7 to
ac3571b
Compare
Contributor
|
If you ignore responses where the target is no longer connected, then you are also preventing any OOB swaps from happening that would have succeeded. Is this intended? What is the reasoning behind this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent
hx-head="merge"responses can remove a stylesheet or blocking script while an earlier response is waiting for its load event. If removal prevents that event from firing, the earlier response never reaches its swap.Track render-critical resources while they load and keep them in the head during concurrent merges. Add a three-second ceiling to the wait so a resource that never settles cannot hold a swap indefinitely. The regression test stalls a stylesheet, performs a second merge, then confirms the stylesheet remains and the first swap completes.
Fixes #4100.
Validation:
npm run test:chrome(1,782 passed, 0 failed, 4 skipped).