Skip to content

Commit 3a03117

Browse files
committed
[NTDLL_APITEST] Improve NtQueryInformationThread test
- Skip ThreadNameInformation test on Windows versions < NTDDI_WIN10_RS1 - Disable Test_ThreadQueryAlignmentProbe as it is too broken
1 parent 83216fe commit 3a03117

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎modules/rostests/apitests/ntdll/NtQueryInformationThread.c‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,6 @@ Test_ThreadHideFromDebuggerClass(void)
278278
NtClose(hWaitEvent);
279279
}
280280

281-
static
282281
void
283282
Test_ThreadQueryAlignmentProbe(void)
284283
{
@@ -548,13 +547,14 @@ Test_ThreadNameInformation(void)
548547

549548
NTDDIVersion = GetNTDDIVersion();
550549
trace("NTDDIVersion: 0x%08lx\n", NTDDIVersion);
551-
if (NTDDIVersion < NTDDI_WIN10_RS1)
550+
if (!is_reactos() && NTDDIVersion < NTDDI_WIN10_RS1)
552551
{
553-
trace("Running %s on NT %hu.%hu(.%hu), it may not work!\n",
552+
skip("Skipping %s on NT %hu.%hu(.%hu), because it is not supported.\n",
554553
__FUNCTION__,
555554
(NTDDIVersion & 0xFF000000) >> 24,
556555
(NTDDIVersion & 0x00FF0000) >> 16,
557556
(NTDDIVersion & 0x000000FF));
557+
return;
558558
}
559559

560560
Status = NtCreateEvent(&hWaitEvent,
@@ -620,6 +620,8 @@ START_TEST(NtQueryInformationThread)
620620
{
621621
Test_ThreadBasicInformationClass();
622622
Test_ThreadHideFromDebuggerClass();
623+
#if 0 // This test is too broken
623624
Test_ThreadQueryAlignmentProbe();
625+
#endif
624626
Test_ThreadNameInformation();
625627
}

0 commit comments

Comments
 (0)