Skip to content

Commit ea313e6

Browse files
xmine64zmtong1988
andauthored
[MSI] Fix not showing combobox items (reactos#9165)
Import fix from Wine-11.6, commit wine-mirror/wine@46e5cab msi: Add ComboBox items, using value if text does not exist. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56296 PR reactos#8971 will upgrade module to Wine-10.0, so guard the change with `#ifdef __REACTOS__`. Fixes CORE-15709. Co-authored-by: Maotong Zhang <zmtong1988@gmail.com>
1 parent 91146de commit ea313e6

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎dll/win32/msi/dialog.c‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1397,7 +1397,11 @@ static UINT combobox_add_item( MSIRECORD *rec, void *param )
13971397

13981398
info->items[info->addpos_items] = wcsdup( value );
13991399

1400+
#ifdef __REACTOS__ /* Import fix from Wine-11.6 */
1401+
pos = SendMessageW( info->hwnd, CB_ADDSTRING, 0, (LPARAM)(text ? text : value) );
1402+
#else
14001403
pos = SendMessageW( info->hwnd, CB_ADDSTRING, 0, (LPARAM)text );
1404+
#endif
14011405
SendMessageW( info->hwnd, CB_SETITEMDATA, pos, (LPARAM)info->items[info->addpos_items] );
14021406
info->addpos_items++;
14031407

0 commit comments

Comments
 (0)