Skip to content

Commit c9788bd

Browse files
committed
fix: improve scrolling behavior in BsWheelColumn to prevent out-of-bounds access
1 parent f5df9b1 commit c9788bd

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

‎registry/native/files/components/ui/bs-wheel-column.tsx‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,13 @@ export function BsWheelColumn<T extends string | number>({
114114

115115
React.useEffect(() => {
116116
const targetIndex = indexForSelected(selectedIndex)
117-
scrollToIndex(targetIndex, false)
118-
}, [indexForSelected, scrollToIndex, selected, selectedIndex])
117+
// Scroll only — avoid setFocusedIndex here (react-hooks/set-state-in-effect).
118+
if (targetIndex < 0 || targetIndex >= data.length) return
119+
listRef.current?.scrollToOffset({
120+
offset: targetIndex * ITEM_HEIGHT,
121+
animated: false,
122+
})
123+
}, [data.length, indexForSelected, selectedIndex])
119124

120125
const commitIndex = React.useCallback(
121126
(index: number) => {

0 commit comments

Comments
 (0)