From 31467d59a5a8e6721af1dc5d6592fad31339bcb9 Mon Sep 17 00:00:00 2001
From: Mateusz Klatt <mateusz@klatt.ie>
Date: Fri, 31 Jul 2026 21:23:49 +0200
Subject: [PATCH] qt: filter addhdkey from RPC console history

The addhdkey RPC accepts a BIP 32 extended private key, but it was not
added to the RPC console sensitive-command filter when introduced. As
a result, the key remains visible in console history.

Add addhdkey to the filter and cover it in rpcnestedtests.
---
 src/qt/rpcconsole.cpp          | 1 +
 src/qt/test/rpcnestedtests.cpp | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
index 3f4da599eb6..63a9035383a 100644
--- a/src/qt/rpcconsole.cpp
+++ b/src/qt/rpcconsole.cpp
@@ -73,6 +73,7 @@ namespace {
 
 // don't add private key handling cmd's to the history
 const QStringList historyFilter = QStringList()
+    << "addhdkey"
     << "createwallet"
     << "createwalletdescriptor"
     << "migratewallet"
diff --git a/src/qt/test/rpcnestedtests.cpp b/src/qt/test/rpcnestedtests.cpp
index 68130df88aa..18587a8366e 100644
--- a/src/qt/test/rpcnestedtests.cpp
+++ b/src/qt/test/rpcnestedtests.cpp
@@ -85,6 +85,8 @@ void RPCNestedTests::rpcNestedTests()
     QVERIFY(result == "4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b");
     QVERIFY(filtered == "getblock(getbestblockhash())[tx][0]");
 
+    RPCConsole::RPCParseCommandLine(nullptr, result, "addhdkey abc", /*fExecute=*/false, &filtered);
+    QVERIFY(filtered == "addhdkey(…)");
     RPCConsole::RPCParseCommandLine(nullptr, result, "createwallet test true", false, &filtered);
     QVERIFY(filtered == "createwallet(…)");
     RPCConsole::RPCParseCommandLine(nullptr, result, "createwalletdescriptor abc", false, &filtered);