[PM-38575] feat: hide payment modal for sales-assisted trials

[cyprain-okeke]

🎟️ Tracking

PM-38575

📔 Objective

Suppress TrialPaymentDialogComponent for sales-assisted trial organizations — they're invoiced through their Bitwarden sales representative, so the self-serve card-entry modal doesn't apply. The trial countdown banner is intentionally unchanged (getFreeTrialWarning$ untouched); banner copy is handled separately in PM-38885.

A few notes for review:

• The guard lives in showSubscribeBeforeFreeTrialEndsDialog$ rather than getWarning$ because the banner must keep receiving the free-trial warning — only the modal path filters on isSalesAssisted.
• The AC's "no payment method saved" condition is server-guaranteed: the freeTrial warning is omitted from the warnings response once a payment method exists, so the guard doesn't re-check it.
• Needs to be lined up with [PM-38574] feat: Set trialInitiationPath for sales-assisted trials server#8272 — until that ships, isSalesAssisted is always false and this change is a no-op.
• Stacked on [PM-38574] feat: Set trialInitiationPath for sales-assisted trials #22757 (PM-38574); this PR targets that branch and will retarget to main when it merges.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the isSalesAssisted guard added to showSubscribeBeforeFreeTrialEndsDialog$ in apps/web/src/app/billing/organizations/warnings/services/organization-warnings.service.ts:266 plus the four accompanying spec changes. The guard is scoped to the modal path only, so getFreeTrialWarning$ and the trial banner keep emitting as the description states, and the new spec at line 211 pins that behavior. Both production consumers (vault.component.ts:360, members.component.ts:252) subscribe through merge(...), so a stream that completes without emitting is safe — this matches the shape the pre-existing warning !== null filter already had, and no firstValueFrom consumer exists that would throw EmptyError. TrialPaymentDialogComponent.open has exactly one production call site inside the guarded switchMap, and isSalesAssisted is a non-optional boolean defaulting to false when the server omits IsSalesAssisted, making this a safe no-op until bitwarden/server#8272 ships.

No findings met the confidence threshold for posting.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.05%. Comparing base (374ff28) to head (b2b22c6).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@                                           Coverage Diff                                            @@
##           billing/pm-38574/set-trial-initiation-path-for-sales-assisted-trials   #22805      +/-   ##
========================================================================================================
- Coverage                                                                 55.05%   55.05%   -0.01%     
========================================================================================================
  Files                                                                      4346     4346              
  Lines                                                                    138567   138567              
  Branches                                                                  21970    21970              
========================================================================================================
- Hits                                                                      76292    76288       -4     
- Misses                                                                    56723    56727       +4     
  Partials                                                                   5552     5552              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.