Bind strict SSRF validation to direct dials - #1
Merged
Conversation
In strict direct mode (WithStrictSSRFProtection + WithNoProxy without WithAllowPrivateRedirects), the IP-policy dial wrapper resolves the request hostname itself with the configured resolver and hands the underlying dialer an already-validated literal IP. This makes the prior WithDialContext/WithResolver contract false for that mode: WithResolver is no longer ignored (it drives the validation lookup) and a custom dialer never receives the original hostname. The behavior is intentional -- it closes the DNS-rebinding window between validation and dial -- so correct the public doc comments to describe the exception rather than change the code. Found via adversarial cross-model review (roast R-8ec3d3). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
justjust test-race