Repository navigation
nextest: Also serialize the test_to_base_disk_* tests - #392
Merged
cgwalters merged 1 commit intoSep 30, 2026
Merged
Conversation
The override that makes VM/install tests take both integration threads matched `to_?disk`, which doesn't cover `to_base_disk`. So the libvirt base-disk tests, which each run a full `bootc install` in a VM, could run two at a time, which is the memory pressure this override exists to avoid. That happened in https://github.com/bootc-dev/bcvk/actions/runs/34886352507, where test_to_base_disk_integration_with_list and test_to_base_disk_with_root_size ran concurrently. Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nextest override that makes VM and
bootc installtests take both integration threads matchesto_?disk, which doesn't cover thetest_to_base_disk_*tests. So those libvirt base-disk tests, each of which runs a full install in a VM, could run two at a time, which is the memory pressure the override exists to avoid. That happened in this run, wheretest_to_base_disk_integration_with_listandtest_to_base_disk_with_root_sizeran concurrently.Tested on a 16-core RHEL 10.2 devspace: with the old filter,
cargo nextest list -P integration -E 'test(/to_?disk/)'matches none of the 5test_to_base_disk_*tests, and with the added clause all 5 are matched (15 tests in total for the two clauses).test_to_base_disk_basicpasses under the integration profile.CI note: the
integration-tests (4)failure is unrelated to this change:test_libvirt_ignition_invalid_pathfailed pullingquay.io/fedora/fedora-coreos:stablewith an unexpected EOF from quay's CDN, the same flake seen on upstream main (example) and targeted by cgwalters-forge#2. The other 23 tests in that partition passed, includingtest_to_base_disk_integration_with_listandtest_to_base_disk_with_root_size, the pair that ran concurrently before.Found while looking into #157.
The
Signed-off-by: Colin Walters <walters@verbum.org>on these commits was added on cgwalters's approval of the review draft: cgwalters-forge#7 (review)Generated-by: https://github.com/cgwalters/#llms