Repository navigation
Conversation
github-actions
Bot
added
area/install
ckyrouac
added
ci/tier-1
ckyrouac
force-pushed
the
preserve-var
branch
from
November 2, 2026 18:34
7b61907 to
e41bfc2
Compare
ckyrouac
marked this pull request as ready for review
November 2, 2026 18:34
github-actions
Bot
added
area/install
The /var copy needs careful filtering around exclusions and nested mounts, and must avoid publishing partial entries or overwriting existing data. Isolating the copy engine and its tests makes these filesystem guarantees reviewable before adding installer orchestration. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
Stored images should be validated before target mutations. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
Users converting an existing package-mode root need an opt-in path to move its state into the new OSTree deployment before reboot. Keep migration behind the existing-root install option and defer destructive cleanup until the copy succeeds, while preserving the established install behavior for other callers. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
Large /var trees are expensive to duplicate when the source and deployment filesystems support copy-on-write clones. Probe the actual source/destination pair, use reflinks when available, and retain a full-copy fallback for unsupported filesystems. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
Users converting package-mode systems need to understand the copy strategy, required backend, exclusions, and lack of snapshot consistency before opting in. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
A /var migration is useful only if copied data remains available after the first reboot. Add a single-guest plan that invokes --preserve-var and verifies a host marker after boot, while keeping TMT workdirs accessible when /var/tmp is excluded. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
The package-mode host's /etc is not migrated by to-existing-root, so a tmpfiles rule written there disappears on reboot. Write and verify the rule in the mounted deployment's persistent /etc before reboot instead. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
The split package-mode test no longer exercised how preserve-var handles a nested bind mount. Add a derived image with an enabled mount and verify copied data and the rebooted mount behavior. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
Reject wipe mode before installation can mutate the running source tree. Make no-clobber collisions visible and clarify the copy, staging, and crash-durability guarantees. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
Clarify that a completed preserve-var copy is not guaranteed to survive sudden power loss or kernel failure, while retaining the consistent-live-snapshot caveat. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
Explain that atomic per-entry namespace visibility does not make the migration a tree-wide snapshot or transaction, and distinguish both from crash durability. This helps operators reason about partial migrations and live database data. Assisted-by: AI Signed-off-by: ckyrouac <ckyrouac@redhat.com>
ckyrouac
force-pushed
the
preserve-var
branch
from
November 2, 2026 18:52
e41bfc2 to
bb305fc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting
--preserve-varoff of #2384