Skip to content

Add FLUENT to restclient IntegrityCheckerType - #1080

Merged
ehoogerbeets merged 3 commits into
box:masterfrom
ehoogerbeets:addFluentRestclientEnum
Sep 1, 2026
Merged

Add FLUENT to restclient IntegrityCheckerType#1080
ehoogerbeets merged 3 commits into
box:masterfrom
ehoogerbeets:addFluentRestclientEnum

Conversation

@ehoogerbeets

Copy link
Copy Markdown
Contributor

Summary

  • Fixes a client/server mismatch: the server IntegrityCheckerType enum includes FLUENT (Fluent integrity checker); the restclient copy did not.
  • Jackson deserializes checkers by name, so repo-view / repo-update (and any other restclient path that reads IntegrityChecker) failed when a repository used a Fluent checker.
  • Adds tests that every restclient enum name deserializes, and that the server and restclient enums have the same name set (not ordinals — those already diverge). A missing name is reported as “on server but missing from restclient” or the reverse.

Split out of #1076 per review.

Test plan

  • mvn -pl restclient,webapp -am test -Dtest=IntegrityCheckerTypeTest -Dsurefire.failIfNoSpecifiedTests=false
  • Confirm repo-view / repo-update succeed for a repository that has a FLUENT integrity checker

Made with Cursor

…r enum.

Jackson deserializes checkers by name, so repo-view/update failed when a repository used a Fluent checker. Tests assert every client name round-trips and that the two enums have the same name set.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ehoogerbeets
ehoogerbeets merged commit f18cfe7 into box:master Sep 1, 2026
4 of 5 checks passed
@ehoogerbeets
ehoogerbeets deleted the addFluentRestclientEnum branch September 1, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants