Held the EMBER browse list back until the scan confirms a dataset holds video - #52
Merged
Merged
Conversation
…ds video Browse EMBER painted every dataset the bucket listing turned up as soon as the listing landed, then cut the list down to the datasets holding video once the archive sweep had read their file lists. On a warm cache that whole window is short, so what a visitor sees is a flash of a list they never asked for followed by most of it disappearing. The list is now confirmed-only wherever a sweep is going to run: rows appear as the sweep lands each dataset that actually holds video, already carrying their video count, and until the first one arrives the list says it is still looking. An archive too large to sweep is unchanged, since nothing about it is confirmable up front. Redraws are coalesced to one a frame so a scan of hundreds of datasets does not rebuild the list hundreds of times. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CFBzpN6VGNZbWev9Ken8c6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browse EMBER painted every dataset from the bucket listing the moment that listing landed, and only cut the list down to the datasets holding video once the archive sweep had read their file lists. The result is a flash of a list nobody asked for, most of which then disappears.
The list is now confirmed-only wherever a sweep is going to run: rows appear as the sweep lands each dataset that holds video, already carrying their video count, and until the first one arrives the list says it is still looking. An archive too large to sweep (
SWEEP_BUDGET_BYTES) is unchanged, since nothing about it is confirmable up front. Sweep-driven redraws are coalesced to one a frame.Adds an integration test that serves the manifests slowly so the window is wide enough to look inside; it fails on
main.Original prompt
when pressing browse EMBER button there is a brief moment where the loaded datasets are completely incorrect and they flash in that card content; by incorrect I mean they don't seem to filter empty or embargoed ahead of time
Generated by Claude Code