Skip to content

feat: Add decisions prompt support - #2769

Open
Luca Forstner (lforst) wants to merge 2 commits into
mainfrom
lforst/dum-e/berlin-50eb783d3f
Open

Luca Forstner (lforst) wants to merge 2 commits into
mainfrom
lforst/dum-e/berlin-50eb783d3f

Conversation

@lforst

Copy link
Copy Markdown
Member
  • Build decisions prompts with text or message inputs and predicate, choice, or score questions. Template variables are rendered in both inputs and questions.
    // New decisions prompt flavor
    const request = prompt.build(variables, { flavor: "decisions" });
  • Support saved and code-defined decisions prompts in scorers, eval parameters, and CLI exports.
  • Define the decisions schema in the SDK so support does not depend on generated platform type updates.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T14:17:27.488633Z e2e2305 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2e23057c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread js/src/prompt-schemas.ts
Comment on lines +19 to +22
content: z.union([
z.string(),
z.array(chatCompletionContentPartTextSchema),
]),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use Decisions content parts instead of Chat Completions parts

For decisions prompts with array-valued message content, this schema accepts only Chat Completions { type: "text", text } parts, whereas the Decisions request contract uses input_text and input_image (see js/src/vendor-sdk-types/openai-decisions.ts and the existing image requests in e2e/scenarios/openai-instrumentation/scenario.impl.mjs). Consequently, valid saved Decisions inputs fail parsing in loadPrompt() or build(), while accepted text parts are returned unchanged by the renderer and produce invalid requests when passed to decisions.create(). Use the Decisions content-part schema and render text parts while preserving image parts.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant