Repository navigation
fix(deps): Upgrade minimatch from v10 to v11 - #2770
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoNov 10, 2026
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Luca Forstner (lforst)
approved these changes
Nov 10, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
fix-minimatch-override-8a36f285
branch
November 10, 2026 21:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the
braintrustpackage'sminimatchdependency from^10.2.5to^11.0.1. All vulnerableminimatchversions are below 11.0.1. Becausebraintrust(up to and including 3.43.0) pinsminimatchto 10.x, downstream users can't get the fix without adding an override.js/package.json:minimatch^10.2.5→^11.0.1. The lockfile resolves to 11.0.5, which adds@isaacs/nonrecursive-glob-matchas a transitive dependency.minimatch, for file pattern matching injs/src/cli/index.ts. The namedminimatchexport it uses hasn't changed, so no code changes were needed.node: 20 || >=22, which matches our CI matrix (20/22/24/26). The^11.0.1floor still lets Node 18 installs resolve to a patched 11.0.1–11.0.3.Testing
pnpm run check:typingsinjs/pnpm exec vitest run src/cli(7 files, 56 tests passing)