Repository navigation
fix: don't crash when the span cache can't write its temp file - #2804
Open
George Shostakovych (gshost1) wants to merge 1 commit into
Open
George Shostakovych (gshost1) wants to merge 1 commit into
George Shostakovych (gshost1) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2803
Summary
SpanCache.queueWrite()kicks offthis.flushWriteBuffer()in the background and stores the promise onthis.flushPromisewithout a.catch()handler. During an experiment-backedEval(), nothing awaitsflushPromise, so if opening or appending to the temp file fails (ENOENTon a missingTMPDIR, read-only container rootfs,ENOSPC/EIO), Node terminates the process with an unhandled promise rejection.This catches initialization and append errors inside
flushWriteBuffer(), logs viadebugLogger.warn, resetsthis.initPromise = nullwhen initialization fails so later writes don't stay permanently stuck on a cached rejected promise, and leaves unwritten spans inwriteBuffersogetByRootSpanId()continues serving them from memory.Verification
js/src/span-cache-flush-failure.test.ts(2 tests covering missingTMPDIRunhandled-rejection suppression + in-memory read fallback; fails onmain, passes with fix)cd js && pnpm exec vp test runacrossspan-cache,trace,framework,framework2, andagent-assertions: 209 passed, 0 failedcd js && pnpm exec tsc --noEmit: clean.changeset/span-cache-flush-errors.md)(Note on interaction with #2767: if merged alongside #2767's serialized drain continuation, the
.then()continuation there should avoid immediately re-invokingflushWriteBuffer()when a flush returns early on disk error so unwritten records don't trigger a tight retry loop.)