eliminate code warnings

Author: stefanseifert

src/services/ConstructionCards.ts

@@ -32,7 +32,9 @@ const cards : ConstructionCard[] = [
 ]
 
 const cardsMap = new Map<number,ConstructionCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/DraftingPriorityCards.ts

@@ -42,7 +42,9 @@ const cards : DraftingPriorityCard[] = [
 ]
 
 const cardsMap = new Map<number,DraftingPriorityCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/DraftingRowCards.ts

@@ -78,7 +78,9 @@ const cards : DraftingRowCard[] = [
 ]
 
 const cardsMap = new Map<number,DraftingRowCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/WarCards.ts

@@ -56,7 +56,9 @@ const cards : WarCard[] = [
 ]
 
 const cardsMap = new Map<number,WarCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

tests/unit/services/RowPlaceholders.spec.ts

@@ -6,10 +6,10 @@ describe('services/RowPlaceholders', () => {
     const rowPlaceholders = RowPlaceholders.new()
 
     expect(rowPlaceholders.rows.length).to.eq(2)
-    rowPlaceholders.rows.forEach(row => {
+    for (const row of rowPlaceholders.rows) {
       expect(row).to.greaterThanOrEqual(1)
       expect(row).to.lessThanOrEqual(4)
-    })
+    }
 
     const persistence = rowPlaceholders.toPersistence()
     expect(persistence.rows.length).to.eq(2)