Eliminate Code Warnings (#46)

Author: stefanseifert

eslint.config.js

@@ -3,7 +3,7 @@ import { defineConfigWithVueTs, vueTsConfigs } from '@vue/eslint-config-typescri
 import pluginVitest from '@vitest/eslint-plugin'
 import pluginPlaywright from 'eslint-plugin-playwright'
 import i18nJsonPlugin from 'eslint-plugin-i18n-json'
-import path from 'path'
+import path from 'node:path'
 
 export default defineConfigWithVueTs(
   {

index.html

@@ -12,7 +12,7 @@
     <link rel="mask-icon" href="/img/icons/maskable-icon-512x512.png" color="#fff">
     <!-- Matomo Tracking: Cookie-less and GDPR-conformant -->
     <script>
-      var _paq = window._paq = window._paq || [];
+      var _paq = globalThis._paq = globalThis._paq || [];
       (function() {
         var u="//matomo.brdgm.me/";
         _paq.push(['setTrackerUrl', u+'matomo.php']);

package-lock.json

@@ -17,7 +17,7 @@
     "generate-pwa-assets": "pwa-assets-generator"
   },
   "dependencies": {
-    "@brdgm/brdgm-commons": "^1.8.0",
+    "@brdgm/brdgm-commons": "^1.8.1",
     "@popperjs/core": "^2.11.8",
     "bootstrap": "^5.3.3",
     "core-js": "^3.41.0",

package.json

@@ -40,7 +40,7 @@ export default defineComponent({
   },
   methods: {
     updateDifficultyLevel(event: Event) {
-      this.difficultyLevel = parseInt((event.target as HTMLInputElement).value)
+      this.difficultyLevel = Number.parseInt((event.target as HTMLInputElement).value)
       this.state.setup.difficultyLevel = this.difficultyLevel
     }
   }

src/components/setup/DifficultyLevel.vue

@@ -32,7 +32,9 @@ const cards : ConstructionCard[] = [
 ]
 
 const cardsMap = new Map<number,ConstructionCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/ConstructionCards.ts

@@ -42,7 +42,9 @@ const cards : DraftingPriorityCard[] = [
 ]
 
 const cardsMap = new Map<number,DraftingPriorityCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/DraftingPriorityCards.ts

@@ -78,7 +78,9 @@ const cards : DraftingRowCard[] = [
 ]
 
 const cardsMap = new Map<number,DraftingRowCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/DraftingRowCards.ts

@@ -56,7 +56,9 @@ const cards : WarCard[] = [
 ]
 
 const cardsMap = new Map<number,WarCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/WarCards.ts

@@ -9,7 +9,7 @@ export const useStateStore = defineStore(`${name}.state`, {
   state: () => {
     return {
       language: 'en',
-      baseFontSize: 1.0,
+      baseFontSize: 1,
       setup: {
         difficultyLevel: DifficultyLevel.NORMAL
       },