Eliminate Code Warnings

eslint.config.js

@@ -3,7 +3,7 @@ import { defineConfigWithVueTs, vueTsConfigs } from '@vue/eslint-config-typescri
 import pluginVitest from '@vitest/eslint-plugin'
 import pluginPlaywright from 'eslint-plugin-playwright'
 import i18nJsonPlugin from 'eslint-plugin-i18n-json'
-import path from 'path'
+import path from 'node:path'
 
 export default defineConfigWithVueTs(
   {

index.html

@@ -12,7 +12,7 @@
     <link rel="mask-icon" href="/img/icons/maskable-icon-512x512.png" color="#fff">
     <!-- Matomo Tracking: Cookie-less and GDPR-conformant -->
     <script>
-      var _paq = window._paq = window._paq || [];
+      var _paq = globalThis._paq = globalThis._paq || [];
       (function() {
         var u="//matomo.brdgm.me/";
         _paq.push(['setTrackerUrl', u+'matomo.php']);

package.json

@@ -17,7 +17,7 @@
     "generate-pwa-assets": "pwa-assets-generator"
   },
   "dependencies": {
-    "@brdgm/brdgm-commons": "^1.8.0",
+    "@brdgm/brdgm-commons": "^1.8.1",
     "@popperjs/core": "^2.11.8",
     "bootstrap": "^5.3.3",
     "core-js": "^3.41.0",

src/components/setup/DifficultyLevel.vue

@@ -40,7 +40,7 @@ export default defineComponent({
   },
   methods: {
     updateDifficultyLevel(event: Event) {
-      this.difficultyLevel = parseInt((event.target as HTMLInputElement).value)
+      this.difficultyLevel = Number.parseInt((event.target as HTMLInputElement).value)
       this.state.setup.difficultyLevel = this.difficultyLevel
     }
   }

src/services/ConstructionCards.ts

@@ -32,7 +32,9 @@ const cards : ConstructionCard[] = [
 ]
 
 const cardsMap = new Map<number,ConstructionCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/DraftingPriorityCards.ts

@@ -42,7 +42,9 @@ const cards : DraftingPriorityCard[] = [
 ]
 
 const cardsMap = new Map<number,DraftingPriorityCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/DraftingRowCards.ts

@@ -78,7 +78,9 @@ const cards : DraftingRowCard[] = [
 ]
 
 const cardsMap = new Map<number,DraftingRowCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/WarCards.ts

@@ -56,7 +56,9 @@ const cards : WarCard[] = [
 ]
 
 const cardsMap = new Map<number,WarCard>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/store/state.ts

@@ -9,7 +9,7 @@ export const useStateStore = defineStore(`${name}.state`, {
   state: () => {
     return {
       language: 'en',
-      baseFontSize: 1.0,
+      baseFontSize: 1,
       setup: {
         difficultyLevel: DifficultyLevel.NORMAL
       },

src/util/getTechColor.ts

@@ -5,7 +5,7 @@ import Tech from '@/services/enum/Tech'
  * @param tech Tech card
  * @returns Color code
  */
-export default function(tech: Tech) : string {
+export default function getTechColor(tech: Tech) : string {
   switch (tech) {
     case Tech.AGRICULTURE:    return '#47914d'
     case Tech.ARMY:           return '#ce372f'

src/util/getTechDuration.ts

@@ -6,7 +6,7 @@ import Tech from '@/services/enum/Tech'
  * @param round Age
  * @returns Tech duration
  */
-export default function(tech: Tech, round: number) : number {
+export default function getTechDuration(tech: Tech, round: number) : number {
   const index = round - 1
   switch (tech) {
     case Tech.AGRICULTURE:    return [2,3,1,2,1,1,2,1][index]

src/util/toTech.ts

@@ -5,7 +5,7 @@ import TechPlaceholder from '@/services/enum/TechPlaceholder'
  * Converts tech placeholder to undefined, keeps tech as is.
  * @returns Tech or undefined
  */
-export default function(tech: (Tech|TechPlaceholder)) : Tech|undefined {
+export default function toTech(tech: (Tech|TechPlaceholder)) : Tech|undefined {
   if (tech == TechPlaceholder.BLANK || tech == TechPlaceholder.EMPTY) {
     return undefined
   }

tests/unit/helper/mockRound.ts

@@ -1,7 +1,7 @@
 import Player from '@/services/enum/Player'
 import { BotCardsPersistence, ProsperityCardsPersistence, Round, RowPlaceholdersPersistence, TechCardSelectionPersistence } from '@/store/state'
 
-export default function (params?: MockRoundParams) : Round {
+export default function mockRound(params?: MockRoundParams) : Round {
   const round : Round = {
     round: params?.round ?? 1,
     startPlayer: params?.startPlayer ?? Player.PLAYER,

tests/unit/helper/mockRouteLocation.ts

@@ -1,6 +1,6 @@
 import { LocationQuery, RouteLocation, RouteMeta, RouteParams, RouteRecord, RouteRecordName } from 'vue-router'
 
-export default function (params?: MockRouteLocationParams) : RouteLocation {
+export default function mockRouteLocation(params?: MockRouteLocationParams) : RouteLocation {
   return {
     name: params?.name,
     path: params?.path ?? '',

tests/unit/helper/mockState.ts

@@ -2,7 +2,7 @@ import DifficultyLevel from '@/services/enum/DifficultyLevel'
 import Player from '@/services/enum/Player'
 import { Round, State } from '@/store/state'
 
-export default function (params?: MockStateParams) : State {  
+export default function mockState(params?: MockStateParams) : State {  
   return {
     language: 'en',
     baseFontSize: 1,

tests/unit/services/RowPlaceholders.spec.ts

@@ -6,10 +6,10 @@ describe('services/RowPlaceholders', () => {
     const rowPlaceholders = RowPlaceholders.new()
 
     expect(rowPlaceholders.rows.length).to.eq(2)
-    rowPlaceholders.rows.forEach(row => {
+    for (const row of rowPlaceholders.rows) {
       expect(row).to.greaterThanOrEqual(1)
       expect(row).to.lessThanOrEqual(4)
-    })
+    }
 
     const persistence = rowPlaceholders.toPersistence()
     expect(persistence.rows.length).to.eq(2)

vite.config.ts

@@ -3,7 +3,7 @@ import { defineConfig } from 'vite'
 import vue from '@vitejs/plugin-vue'
 import { VitePWA } from 'vite-plugin-pwa'
 import VueI18nPlugin from '@intlify/unplugin-vue-i18n/vite'
-import path from 'path'
+import path from 'node:path'
 import { description, appDeployName } from './package.json'
 import legacy from '@vitejs/plugin-legacy'