Eliminate Code Warnings (#26)

Author: stefanseifert

eslint.config.js

@@ -3,7 +3,7 @@ import { defineConfigWithVueTs, vueTsConfigs } from '@vue/eslint-config-typescri
 import pluginVitest from '@vitest/eslint-plugin'
 import pluginPlaywright from 'eslint-plugin-playwright'
 import i18nJsonPlugin from 'eslint-plugin-i18n-json'
-import path from 'path'
+import path from 'node:path'
 
 export default defineConfigWithVueTs(
   {

index.html

@@ -12,7 +12,7 @@
     <link rel="mask-icon" href="/img/icons/maskable-icon-512x512.png" color="#fff">
     <!-- Matomo Tracking: Cookie-less and GDPR-conformant -->
     <script>
-      var _paq = window._paq = window._paq || [];
+      var _paq = globalThis._paq = globalThis._paq || [];
       (function() {
         var u="//matomo.brdgm.me/";
         _paq.push(['setTrackerUrl', u+'matomo.php']);

package-lock.json

@@ -17,7 +17,7 @@
     "generate-pwa-assets": "pwa-assets-generator"
   },
   "dependencies": {
-    "@brdgm/brdgm-commons": "^1.7.4",
+    "@brdgm/brdgm-commons": "^1.8.1",
     "@popperjs/core": "^2.11.8",
     "bootstrap": "^5.3.3",
     "core-js": "^3.40.0",

package.json

@@ -36,7 +36,7 @@ export default defineComponent({
   },
   methods: {
     updateDifficultyLevel(event: Event) {
-      this.difficultyLevel = parseInt((event.target as HTMLInputElement).value)
+      this.difficultyLevel = Number.parseInt((event.target as HTMLInputElement).value)
       this.state.setup.difficultyLevel = this.difficultyLevel
     }
   }

src/components/setup/DifficultyLevel.vue

@@ -76,7 +76,9 @@ export default class CardDeck {
   public drawAll() : void {
     this._leftMajoritySlot = this.draw()
     this._rightMajoritySlot = this.draw()
-    this._availableSlots.forEach(slot => this._slots.push({slot:slot, card:this.draw(), flipped:false}))
+    for (const slot of this._availableSlots) {
+      this._slots.push({slot:slot, card:this.draw(), flipped:false})
+    }
   }
 
   /**

src/services/CardDeck.ts

@@ -512,7 +512,9 @@ const cards = [
 ]
 
 const cardsMap = new Map<string,Card>()
-cards.forEach(card => cardsMap.set(card.id, card))
+for (const card of cards) {
+  cardsMap.set(card.id, card)
+}
 
 export default {
 

src/services/Cards.ts

@@ -36,7 +36,9 @@ export default class InitialLunaStates {
     }
 
     // draw cards for new round
-    lunaStates.forEach(this.drawCards)
+    for (const lunaState of lunaStates) {
+      this.drawCards(lunaState)
+    }
 
     // store round
     const lunaStatesPersistence = lunaStates.map(item => item.toPersistence())

src/services/InitialLunaStates.ts

@@ -8,7 +8,7 @@ export const useStateStore = defineStore(`${name}.store`, {
   state: () => {
     return {
       language: 'en',
-      baseFontSize: 1.0,
+      baseFontSize: 1,
       setup: {
         playerSetup: {
           playerCount: 1,

src/store/state.ts

@@ -19,8 +19,8 @@ export default abstract class AbstractNavigationState {
     this.playerColors = setup.playerSetup.playerColors
     this.botCount = setup.playerSetup.botCount
 
-    this.round = parseInt(route.params['round'] as string)
-    this.turn = parseInt(route.params['turn'] as string)
+    this.round = Number.parseInt(route.params['round'] as string)
+    this.turn = Number.parseInt(route.params['turn'] as string)
   }
 
 }