Skip to content

tac: remove user-configurable buffer size option - #1038

Merged
briandfoy merged 1 commit into
briandfoy:masterfrom
mknos:tac-bufsz
Jun 5, 2026
Merged

tac: remove user-configurable buffer size option#1038
briandfoy merged 1 commit into
briandfoy:masterfrom
mknos:tac-bufsz

Conversation

@mknos

@mknos mknos commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

The "-S size_bytes" option does not appear in other versions of tac and it seems over-complicated to include one here. The NetBSD and DragonFlyBSD versions of tac do not support any options. Probably the reference implementation for initial development was GNU, but that only has -b, - r and -s sep_value. Technically the -B flag isn't provided by GNU tac either, but I decided to leave it.

Default buffer size becomes a constant so it is easy to customise.

Regression test...

%/usr/bin/tac --version
tac (GNU coreutils) 8.30
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Jay Lepreau and David MacKenzie.
%/usr/bin/tac tac  > a && perl tac tac > b && perl cmp a b 
%

The "-S size_bytes" option does not appear in other versions of tac and it seems over-complicated to include one here.
The NetBSD and DragonFlyBSD versions of tac do not support any options. Probably the reference implementation for initial development was GNU, but that only has -b, - r and -s sep_value. Technically the -B flag isn't provided by GNU tac either, but I decided to leave it.
@mknos
mknos temporarily deployed to housekeeping June 5, 2026 09:21 — with GitHub Actions Inactive
@github-actions github-actions Bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tac The tac program Status: needs verification issue needs to be verified Type: bug an existing feature does not work labels Jun 5, 2026
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@mknos
mknos temporarily deployed to automated_testing June 5, 2026 09:22 — with GitHub Actions Inactive
@briandfoy briandfoy removed the Type: bug an existing feature does not work label Jun 5, 2026
@briandfoy briandfoy removed the Type: enhancement improve a feature that already exists label Jun 5, 2026
@briandfoy

Copy link
Copy Markdown
Owner

changes: remove non-standard -S switch

@briandfoy
briandfoy merged commit fb1ddad into briandfoy:master Jun 5, 2026
23 of 24 checks passed
@github-actions github-actions Bot added Status: accepted The fix is accepted and removed Status: needs verification issue needs to be verified Priority: low get to this whenever labels Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Program: tac The tac program Status: accepted The fix is accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants