fix(general): handle single and trailing-comma output file paths - #7653
Open
KaoKsn wants to merge 2 commits into
Open
fix(general): handle single and trailing-comma output file paths#7653KaoKsn wants to merge 2 commits into
KaoKsn wants to merge 2 commits into
Conversation
Fixes Issue: bridgecrewio#7645 Fix crashes caused by an empty file path in output_paths when a trailing comma is provided. checkov -f target.tf -o json -o junitxml --output-file-path result.json, Ensure that a single --output-file-path value is treated as a file rather than a directory, so: checkov -f target.tf -o json --output-file-path result.json creates result.json instead of result.json/results_json.json. Add tests covering single output paths and preventing nested output files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fixes Issue: #7645
Description
Fix crashes caused by an empty file path in output_paths when a trailing comma is provided.
Ensure that a single --output-file-path value is treated as a file rather than a directory, so:
creates
result.jsoninstead ofresult.json/results_json.jsonAdd tests covering single output paths and preventing nested output files.
Motivation: Usage lead to finding the bug.
Fixes #7645
Fixes all the problems that issue(#7645) states, expect the output is printed to the console since nothing was suggested for the second problem the issue states.
Checklist: