Feature/hardhat typescript - #3
Open
azizazlan wants to merge 9 commits into
Open
Conversation
Contributor
|
Thanks for this PR!.... Could you please add In it's current form, this is really hard to review :/ |
Author
|
Alright, will do.
…On Sat, 19 Mar 2022 at 11:22 AM, Patrick Collins ***@***.***> wrote:
Thanks for this PR!.... Could you please add artifacts to .gitignore
though? And change your formatting to be the same as what I have before a
PR?
In it's current form, this is really hard to review :/
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFSXJZGUE7JD3PUGK74XOLVAVB57ANCNFSM5Q55APLA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Oh wait... I see what you're looking to do now. You're trying to make this like this? https://github.com/PatrickAlphaC/dao-template We made a hardhat edition above! |
Author
|
You are correct. Ok I will stop working on my repo and will not continue.
Anyway thank you for pointing to the repo. I should have searched github
thoroughly.
…On Sun, 20 Mar 2022 at 07:27, Patrick Collins ***@***.***> wrote:
Oh wait... I see what you're looking to do now.
You're trying to make this like this?
https://github.com/PatrickAlphaC/dao-template
We made a hardhat edition above!
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFSXJYQGKP3Y7TKNO4BZETVAZPFTANCNFSM5Q55APLA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hardhat-typescript support. To run the hardhat task: