Skip to content

Commit 291bc89

Browse files
JuliaEdomclaude
andcommitted
fix(ci): mypy override for optional perplexity client instead of inline ignore
CI has been red since 2026-06-17: the unofficial helallao perplexity client is an optional local install absent in CI, so `import perplexity` raised import-not-found there while the inline `type: ignore[import-untyped]` only covered the installed-but-untyped local case — and any widened inline code list trips unused-ignore on whichever side doesn't need it. A per-module ignore_missing_imports override covers both environments. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent bfc708f commit 291bc89

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎pyproject.toml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,3 +114,9 @@ ignore_missing_imports = true
114114
[[tool.mypy.overrides]]
115115
module = ["plotly.*", "streamlit", "pandas", "pandas.*"]
116116
ignore_missing_imports = true
117+
118+
# Unofficial Perplexity client (github.com/helallao/perplexity-ai): optional
119+
# local install, absent in CI — silence both import-untyped and import-not-found.
120+
[[tool.mypy.overrides]]
121+
module = ["perplexity"]
122+
ignore_missing_imports = true

‎src/nl_sql/llm/providers/helallao_perplexity.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def __init__(
6363
if not model.strip():
6464
raise ProviderError("HelallaoPerplexityProvider requires non-empty model")
6565
try:
66-
import perplexity as _pplx # type: ignore[import-untyped]
66+
import perplexity as _pplx
6767
except ImportError as e:
6868
raise ProviderError(
6969
"helallao perplexity-ai not installed. Run: "

0 commit comments

Comments
 (0)