|
| 1 | +"""Unit tests for the GraceKelly orchestrate provider (AgentFlow ADR 0008 slot). |
| 2 | +
|
| 3 | +Mock the HTTP layer so these run without a live GraceKelly server; a live smoke |
| 4 | +is done separately against a running instance. |
| 5 | +""" |
| 6 | + |
| 7 | +from __future__ import annotations |
| 8 | + |
| 9 | +import io |
| 10 | +import json |
| 11 | +from typing import Any |
| 12 | +from unittest import mock |
| 13 | +from urllib import error as urlerror |
| 14 | + |
| 15 | +import pytest |
| 16 | + |
| 17 | +from nl_sql.llm.providers import GenerateRequest, ProviderError, build_provider |
| 18 | +from nl_sql.llm.providers.gracekelly import GraceKellyProvider |
| 19 | + |
| 20 | + |
| 21 | +class _FakeResponse(io.BytesIO): |
| 22 | + def __enter__(self) -> _FakeResponse: |
| 23 | + return self |
| 24 | + |
| 25 | + def __exit__(self, *exc: object) -> None: |
| 26 | + self.close() |
| 27 | + |
| 28 | + |
| 29 | +def _orchestrate_body(**overrides: Any) -> bytes: |
| 30 | + payload = { |
| 31 | + "status": "completed", |
| 32 | + "output_text": "SELECT COUNT(*) FROM orders_v2 WHERE status = 'cancelled';", |
| 33 | + "model": {"id": "claude-sonnet-5-0", "display_name": "Claude Sonnet 5.0"}, |
| 34 | + "failure_message": None, |
| 35 | + } |
| 36 | + payload.update(overrides) |
| 37 | + return json.dumps(payload).encode("utf-8") |
| 38 | + |
| 39 | + |
| 40 | +def test_factory_builds_gracekelly_with_sonnet_5() -> None: |
| 41 | + provider = build_provider("gracekelly") |
| 42 | + assert isinstance(provider, GraceKellyProvider) |
| 43 | + assert provider.name == "gracekelly" |
| 44 | + assert provider.model == "claude-sonnet-5" |
| 45 | + |
| 46 | + |
| 47 | +def test_generate_posts_orchestrate_and_parses_output_text() -> None: |
| 48 | + captured: dict[str, Any] = {} |
| 49 | + |
| 50 | + def fake_urlopen(req: Any, timeout: float | None = None) -> _FakeResponse: |
| 51 | + captured["url"] = req.full_url |
| 52 | + captured["body"] = json.loads(req.data.decode("utf-8")) |
| 53 | + return _FakeResponse(_orchestrate_body()) |
| 54 | + |
| 55 | + provider = GraceKellyProvider(model="claude-sonnet-5", base_url="http://127.0.0.1:8011") |
| 56 | + with mock.patch("nl_sql.llm.providers.gracekelly.urlrequest.urlopen", fake_urlopen): |
| 57 | + resp = provider.generate(GenerateRequest(prompt="how many orders were cancelled?")) |
| 58 | + |
| 59 | + assert captured["url"] == "http://127.0.0.1:8011/api/v1/orchestrate" |
| 60 | + assert captured["body"] == { |
| 61 | + "prompt": "how many orders were cancelled?", |
| 62 | + "model": "claude-sonnet-5", |
| 63 | + } |
| 64 | + assert resp.text == "SELECT COUNT(*) FROM orders_v2 WHERE status = 'cancelled';" |
| 65 | + assert resp.model == "claude-sonnet-5-0" |
| 66 | + |
| 67 | + |
| 68 | +def test_generate_prepends_system_prompt() -> None: |
| 69 | + captured: dict[str, Any] = {} |
| 70 | + |
| 71 | + def fake_urlopen(req: Any, timeout: float | None = None) -> _FakeResponse: |
| 72 | + captured["body"] = json.loads(req.data.decode("utf-8")) |
| 73 | + return _FakeResponse(_orchestrate_body()) |
| 74 | + |
| 75 | + provider = GraceKellyProvider() |
| 76 | + with mock.patch("nl_sql.llm.providers.gracekelly.urlrequest.urlopen", fake_urlopen): |
| 77 | + provider.generate( |
| 78 | + GenerateRequest(system="You are a DuckDB SQL generator.", prompt="revenue?") |
| 79 | + ) |
| 80 | + |
| 81 | + assert captured["body"]["prompt"] == "You are a DuckDB SQL generator.\n\nrevenue?" |
| 82 | + |
| 83 | + |
| 84 | +def test_generate_unwraps_sql_json_envelope() -> None: |
| 85 | + envelope = json.dumps({"sql": "SELECT 1", "rationale": "trivial"}) |
| 86 | + |
| 87 | + def fake_urlopen(req: Any, timeout: float | None = None) -> _FakeResponse: |
| 88 | + return _FakeResponse(_orchestrate_body(output_text=envelope)) |
| 89 | + |
| 90 | + provider = GraceKellyProvider() |
| 91 | + with mock.patch("nl_sql.llm.providers.gracekelly.urlrequest.urlopen", fake_urlopen): |
| 92 | + resp = provider.generate(GenerateRequest(prompt="q")) |
| 93 | + |
| 94 | + assert resp.text == "SELECT 1" |
| 95 | + |
| 96 | + |
| 97 | +def test_generate_raises_on_orchestrate_failure() -> None: |
| 98 | + def fake_urlopen(req: Any, timeout: float | None = None) -> _FakeResponse: |
| 99 | + return _FakeResponse(_orchestrate_body(output_text="", failure_message="browser timeout")) |
| 100 | + |
| 101 | + provider = GraceKellyProvider() |
| 102 | + with ( |
| 103 | + mock.patch("nl_sql.llm.providers.gracekelly.urlrequest.urlopen", fake_urlopen), |
| 104 | + pytest.raises(ProviderError, match="browser timeout"), |
| 105 | + ): |
| 106 | + provider.generate(GenerateRequest(prompt="q")) |
| 107 | + |
| 108 | + |
| 109 | +def test_generate_wraps_http_error() -> None: |
| 110 | + def fake_urlopen(req: Any, timeout: float | None = None) -> _FakeResponse: |
| 111 | + raise urlerror.HTTPError(req.full_url, 422, "Unsupported model", {}, io.BytesIO(b"nope")) # type: ignore[arg-type] |
| 112 | + |
| 113 | + provider = GraceKellyProvider() |
| 114 | + with ( |
| 115 | + mock.patch("nl_sql.llm.providers.gracekelly.urlrequest.urlopen", fake_urlopen), |
| 116 | + pytest.raises(ProviderError, match="422"), |
| 117 | + ): |
| 118 | + provider.generate(GenerateRequest(prompt="q")) |
| 119 | + |
| 120 | + |
| 121 | +def test_empty_model_rejected() -> None: |
| 122 | + with pytest.raises(ProviderError): |
| 123 | + GraceKellyProvider(model=" ") |
0 commit comments