Skip to content

Commit 9879196

Browse files
JuliaEdomclaude
andcommitted
build(images): move the two Dockerfile build pins with the lock
cde3834 took build 1.6.0 in uv.lock and publish-pypi.yml but stopped there, and test_demo_image_build_pins.py failed on main exactly as designed: Dockerfile.api and deploy/hf-space/Dockerfile pin `build==<the version uv.lock resolves>` because `python -m build --no-isolation` makes that pin the builder that actually runs. A lock bump that leaves them behind means the image builds its wheel with a different -- and now yanked -- builder than CI resolves. The miss was mine and mechanical: I grepped for the pin under .github/, scripts/ and docs/ only, so the two Dockerfiles never showed up. The ratchet is the reason this cost one red run instead of a divergence nobody noticed. Verified: test_demo_image_build_pins.py and test_publish_workflows.py pass (10 passed), and all three tests that read uv.lock pass (32 passed). No `build==1.5.1` remains anywhere in the tree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ybRVCaL1Lyd9d5kFTndh3
1 parent cde3834 commit 9879196

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎Dockerfile.api‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ COPY packaging /build/packaging
2121
# a reproducibility input for the artifact: with --no-isolation its only job is
2222
# installing these two pinned distributions.
2323
RUN pip install --no-cache-dir --upgrade pip \
24-
&& pip install --no-cache-dir build==1.5.1 hatchling==1.31.0 \
24+
&& pip install --no-cache-dir build==1.6.0 hatchling==1.31.0 \
2525
&& python -m build --wheel --no-isolation --outdir /tmp/dist
2626

2727
FROM python:3.11-slim@sha256:9c900dea9e8fb7e16277c179b555cc72d29a352dbc33cff48ad5a0412fd5bfc7

‎deploy/hf-space/Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ WORKDIR /src
3232
# Mirrors Dockerfile.api: pinned build backend, and --no-isolation so the pin is
3333
# what builds the wheel instead of a fresh PyPI download inside build's venv.
3434
RUN pip install --no-cache-dir --upgrade pip \
35-
&& pip install --no-cache-dir build==1.5.1 hatchling==1.31.0 \
35+
&& pip install --no-cache-dir build==1.6.0 hatchling==1.31.0 \
3636
&& python -m build --wheel --no-isolation --outdir /tmp/dist
3737

3838
FROM python:3.11-slim@sha256:9c900dea9e8fb7e16277c179b555cc72d29a352dbc33cff48ad5a0412fd5bfc7

0 commit comments

Comments
 (0)