fix: address review — handle session re-attach, remove dead code

- ConsoleCollector.attach() now updates session mapping on re-attach
  instead of early-returning, preventing silent event drops after
  target detach/re-attach (e.g. tab crash, cross-process navigation)
- Remove unused clearConsoleLogs() and ConsoleCollector.clear()

Author: shivammittal274

packages/browseros-agent/apps/server/src/browser/browser.ts

@@ -1261,8 +1261,4 @@ export class Browser {
     await this.resolveSession(page)
     return this.consoleCollector.getLogs(page, opts)
   }
-
-  async clearConsoleLogs(page: number): Promise<void> {
-    this.consoleCollector.clear(page)
-  }
 }

packages/browseros-agent/apps/server/src/browser/console-collector.ts

@@ -104,8 +104,14 @@ export class ConsoleCollector {
   }
 
   attach(pageId: number, sessionId: string): void {
-    if (this.buffers.has(pageId)) return
-    this.buffers.set(pageId, [])
+    if (!this.buffers.has(pageId)) {
+      this.buffers.set(pageId, [])
+    }
+    // Clean up old session mapping if session changed (re-attach after detach)
+    const oldSession = this.pageToSession.get(pageId)
+    if (oldSession && oldSession !== sessionId) {
+      this.sessionToPage.delete(oldSession)
+    }
     this.sessionToPage.set(sessionId, pageId)
     this.pageToSession.set(pageId, sessionId)
   }
@@ -147,12 +153,6 @@ export class ConsoleCollector {
     return { entries, totalCount }
   }
 
-  clear(pageId: number): void {
-    if (this.buffers.has(pageId)) {
-      this.buffers.set(pageId, [])
-    }
-  }
-
   private addEntry(pageId: number, entry: ConsoleEntry): void {
     const buffer = this.buffers.get(pageId)
     if (!buffer) return