fix: address PR review comments for 0317-fix_input_clear_and_fill

Author: shadowfax92

packages/browseros-agent/apps/server/src/browser/browser.ts

@@ -818,14 +818,24 @@ export class Browser {
     }
 
     if (clear) {
-      const cleared = await elements.clearEditableElement(session, element)
-      if (!cleared || (await elements.getInputValue(session, element))) {
-        await keyboard.clearField(session)
-        if (coords) {
-          const value = await elements.getInputValue(session, element)
-          if (value) {
-            await mouse.dispatchClick(session, coords.x, coords.y, 'left', 3, 0)
-            if (!text) await keyboard.pressCombo(session, 'Backspace')
+      const existingValue = await elements.getInputValue(session, element)
+      if (existingValue) {
+        const cleared = await elements.clearEditableElement(session, element)
+        if (!cleared || (await elements.getInputValue(session, element))) {
+          await keyboard.clearField(session)
+          if (coords) {
+            const value = await elements.getInputValue(session, element)
+            if (value) {
+              await mouse.dispatchClick(
+                session,
+                coords.x,
+                coords.y,
+                'left',
+                3,
+                0,
+              )
+              if (!text) await keyboard.pressCombo(session, 'Backspace')
+            }
           }
         }
       }

packages/browseros-agent/apps/server/src/browser/keyboard.ts

@@ -1,6 +1,8 @@
 import { platform } from 'node:os'
 import type { ProtocolApi } from '@browseros/cdp-protocol/protocol-api'
 
+const PLATFORM_MODIFIER = platform() === 'darwin' ? 4 : 2
+
 type KeyInfo = { code: string; keyCode: number | undefined }
 
 const KEY_MAP: Record<string, KeyInfo> = {
@@ -181,9 +183,32 @@ export async function typeText(
 }
 
 export async function clearField(session: ProtocolApi): Promise<void> {
-  const selectAllCombo = platform() === 'darwin' ? 'Meta+A' : 'Control+A'
-  await pressCombo(session, selectAllCombo)
-  await pressCombo(session, 'Backspace')
+  await session.Input.dispatchKeyEvent({
+    type: 'keyDown',
+    key: 'a',
+    code: 'KeyA',
+    modifiers: PLATFORM_MODIFIER,
+    windowsVirtualKeyCode: 65,
+  })
+  await session.Input.dispatchKeyEvent({
+    type: 'keyUp',
+    key: 'a',
+    code: 'KeyA',
+    modifiers: PLATFORM_MODIFIER,
+    windowsVirtualKeyCode: 65,
+  })
+  await session.Input.dispatchKeyEvent({
+    type: 'keyDown',
+    key: 'Backspace',
+    code: 'Backspace',
+    windowsVirtualKeyCode: 8,
+  })
+  await session.Input.dispatchKeyEvent({
+    type: 'keyUp',
+    key: 'Backspace',
+    code: 'Backspace',
+    windowsVirtualKeyCode: 8,
+  })
 }
 
 function parseKeyCombo(input: string): {

packages/browseros-agent/apps/server/tests/tools/keyboard.test.ts

@@ -1,5 +1,7 @@
 import { describe, expect, it } from 'bun:test'
+import { platform } from 'node:os'
 import {
+  clearField,
   getKeyInfo,
   modifierBitmask,
   normalizeKey,
@@ -158,3 +160,48 @@ describe('pressCombo validation', () => {
     )
   })
 })
+
+describe('clearField', () => {
+  it('uses lowercase select-all without standalone modifier events', async () => {
+    const events: Array<Record<string, unknown>> = []
+    const fakeSession = {
+      Input: {
+        dispatchKeyEvent: async (event: Record<string, unknown>) => {
+          events.push(event)
+        },
+      },
+    } as unknown as Parameters<typeof clearField>[0]
+
+    await clearField(fakeSession)
+
+    const modifier = platform() === 'darwin' ? 4 : 2
+    expect(events).toEqual([
+      {
+        type: 'keyDown',
+        key: 'a',
+        code: 'KeyA',
+        modifiers: modifier,
+        windowsVirtualKeyCode: 65,
+      },
+      {
+        type: 'keyUp',
+        key: 'a',
+        code: 'KeyA',
+        modifiers: modifier,
+        windowsVirtualKeyCode: 65,
+      },
+      {
+        type: 'keyDown',
+        key: 'Backspace',
+        code: 'Backspace',
+        windowsVirtualKeyCode: 8,
+      },
+      {
+        type: 'keyUp',
+        key: 'Backspace',
+        code: 'Backspace',
+        windowsVirtualKeyCode: 8,
+      },
+    ])
+  })
+})