Skip to content

Commit a00602d

Browse files
authored
ci(app-onboard): run the app-onboard checks on PRs (#2414)
* ci(app-onboard): run the app-onboard checks on PRs The Tests workflow discovers suites from ci/affected-suites.ts, and app-onboard was not registered, so a PR touching it reported "0 suites affected" and never ran its tests. Add an app-onboard suite (mirrors claw-onboard) plus its package mapping so `bun run test` runs when the app is affected, and add epic/app-onboard to code-quality's branch list so Biome, Typecheck (Turbo --affected), and Fallow run on the epic PRs too. Editing ci/ is a harness change, so this run exercises the full matrix and self-verifies the discovery. * ci: drop the stale feat/claw-server-bootstrap trigger from code-quality
1 parent eaa56fe commit a00602d

3 files changed

Lines changed: 16 additions & 1 deletion

File tree

.github/workflows/code-quality.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
pull_request:
55
branches:
66
- main
7-
- feat/claw-server-bootstrap
7+
- epic/app-onboard
88
paths:
99
- ".github/workflows/code-quality.yml"
1010
- "packages/browseros-agent/**"

packages/browseros-agent/ci/affected-suites.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@ describe('computeAffectedSuites', () => {
2727
])
2828
})
2929

30+
it('maps an app-onboard change to only the app-onboard suite', () => {
31+
expect(
32+
suiteNames([pkg('@browseros/app-onboard', 'apps/app-onboard')]),
33+
).toEqual(['app-onboard'])
34+
})
35+
3036
it('maps the server package to all seven server suites', () => {
3137
expect(suiteNames([pkg('@browseros/server', 'apps/server')])).toEqual([
3238
'server-agent',
@@ -143,6 +149,7 @@ describe('computeAffectedSuites', () => {
143149
pkg('@browseros/app', 'apps/app'),
144150
pkg('@browseros/claw-app', 'apps/claw-app'),
145151
pkg('@browseros/claw-onboard', 'apps/claw-onboard'),
152+
pkg('@browseros/app-onboard', 'apps/app-onboard'),
146153
pkg('@browseros/build-server-tools', 'packages/build-server-tools'),
147154
pkg('@browseros/claw-server-rust', 'apps/claw-server-rust'),
148155
]

packages/browseros-agent/ci/affected-suites.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,13 @@ export const SUITES: Record<string, SuiteConfig> = {
9494
needs_browser: false,
9595
needs_rust: false,
9696
},
97+
'app-onboard': {
98+
suite: 'app-onboard',
99+
command: '(cd apps/app-onboard && bun run test)',
100+
junit_path: 'test-results/app-onboard.xml',
101+
needs_browser: false,
102+
needs_rust: false,
103+
},
97104
build: {
98105
suite: 'build',
99106
command: 'bun run ./scripts/run-bun-test.ts ./scripts/build',
@@ -146,6 +153,7 @@ const PACKAGE_SUITES: Record<string, string[]> = {
146153
'@browseros/app': ['agent'],
147154
'@browseros/claw-app': ['claw-app'],
148155
'@browseros/claw-onboard': ['claw-onboard'],
156+
'@browseros/app-onboard': ['app-onboard'],
149157
// The build suite exercises scripts/build, which uses build-server-tools, so
150158
// an affected build-server-tools (or a scripts/ change, handled below) runs it.
151159
'@browseros/build-server-tools': ['build'],

0 commit comments

Comments
 (0)