fix: hide bookmark bar tab groups by default

[Nikhil (shadowfax92)]

Summary

• Default the bookmark bar tab-groups entry to hidden in BrowserOS.
• Use the same hidden default in BrowserClaw.
• Update the existing BrowserOS core Chromium patch layer.

Design

Register prefs::kShowTabGroupsInBookmarkBar with a product-independent false default while leaving the product-specific toolbar-control defaults unchanged.

Test plan

• /Users/shadowfax/.skills/sf-mux/scripts/sfmux pool build -- autoninja -C out/Default_browseros_arm64 chrome
• Chromium patch byte-match and apply-check verification (1/1)

[Nikhil (shadowfax92)]

Greptile (@greptileai) review

[Nikhil (shadowfax92)]

Claude (@claude) review

[claude]

Claude finished Nikhil (@shadowfax92)'s task in 1m 29s —— View job

---

Claude finished reviewing this PR

• Gather context (diff, related patch files)
• Understand the request
• Review the changed file
• Post review feedback

Review

The core change itself is correct and minimal: RegisterProfilePrefs in browseros_prefs.cc now registers prefs::kShowTabGroupsInBookmarkBar with a hard-coded false default instead of !IsBrowserClawProduct(), and the now-unused show_tab_groups_in_bookmark_bar_by_default local was removed cleanly (no dangling references). show_toolbar_controls_by_default / IsBrowserClawProduct() usage for the other toolbar prefs is untouched, matching the PR's stated design.

However, this PR only touches browseros_prefs.cc and leaves two sibling patch files in the same directory inconsistent with the new default, which will break tests/docs:

1. packages/browseros/chromium_patches/chrome/browser/browseros/core/browseros_prefs_unittest.cc (not modified by this PR) still asserts the old product-dependent default:

   • ShowTabGroupsInBookmarkBarDefaultMatchesBakedProduct (line 41) does EXPECT_EQ(!IsBrowserClawProduct(), pref_service.GetBoolean(prefs::kShowTabGroupsInBookmarkBar)). On a BrowserOS build, !IsBrowserClawProduct() is true, but the pref now always defaults to false — this test will fail.
   • BrowserOSDefaultsToShowingTabGroupsInBookmarkBar (line 59, under BROWSEROS_ALLOW_RUNTIME_PRODUCT_OVERRIDE) explicitly overrides the product to BrowserOS and asserts EXPECT_TRUE(...) — this will also now fail since the default is false regardless of product override.

   Fix this →

2. packages/browseros/chromium_patches/chrome/browser/browseros/core/browseros_prefs.h (lines 41-42) still documents the old behavior: // Boolean: Show saved tab groups in the bookmark bar (default: true, false for BrowserClaw). This comment is now stale and should say the pref defaults to false for all products.

   Fix this →

The PR's test plan lists a successful chrome build and patch byte-match/apply-check, but doesn't mention running the browseros_prefs_unittest.cc suite — which is why these now-contradictory assertions weren't caught. Worth running that unit test target (or updating it in this PR) before merging.
· Branch: feat/hide-tab-groups-patches

[greptile-apps]

Greptile Summary

The PR changes the bookmark-bar tab-group preference to default to hidden for both BrowserOS and BrowserClaw while retaining product-specific defaults for other toolbar controls.

• Replaces the product-dependent tab-group default with an unconditional false value.
• Leaves existing product-default unit tests inconsistent with the new behavior.

Confidence Score: 4/5

The preference change is non-blocking, but the stale BrowserOS default assertions should be updated so the affected unit tests pass.

The runtime behavior matches the PR design, while two existing tests still enforce the removed product-dependent default.

Files Needing Attention: packages/browseros/chromium_patches/chrome/browser/browseros/core/browseros_prefs.cc and packages/browseros/chromium_patches/chrome/browser/browseros/core/browseros_prefs_unittest.cc

Important Files Changed

Filename	Overview
packages/browseros/chromium_patches/chrome/browser/browseros/core/browseros_prefs.cc	Correctly implements the described product-independent hidden default, but the existing BrowserOS default tests were not updated and will fail.

Prompt To Fix All With AI

### Issue 1
packages/browseros/chromium_patches/chrome/browser/browseros/core/browseros_prefs.cc:34
**Stale product-default preference tests**

The new product-independent `false` default conflicts with the existing tests that still expect BrowserOS to default to `true`, so those tests fail until their assertions are updated to reflect the intended hidden default.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

_{Reviews (1): Last reviewed commit: "fix(patches): hide bookmark bar tab grou..." | Re-trigger Greptile}

[greptile-apps]

Stale product-default preference tests

The new product-independent false default conflicts with the existing tests that still expect BrowserOS to default to true, so those tests fail until their assertions are updated to reflect the intended hidden default.

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/browseros/chromium_patches/chrome/browser/browseros/core/browseros_prefs.cc
Line: 34

Comment:
**Stale product-default preference tests**

The new product-independent `false` default conflicts with the existing tests that still expect BrowserOS to default to `true`, so those tests fail until their assertions are updated to reflect the intended hidden default.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!