Skip to content

Commit 6a917fa

Browse files
Only warn on explicit get_trade_volume fee_info use (#463)
Fixes `get_trade_volume`'s `fee_info` deprecation warning firing on every call by defaulting it to `None` so the warning only triggers when a caller explicitly passes it.
1 parent 1f93840 commit 6a917fa

1 file changed

Lines changed: 12 additions & 11 deletions

File tree

‎src/kraken/spot/user.py‎

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -916,7 +916,7 @@ def get_trade_volume(
916916
self: User,
917917
pair: str | list[str] | None = None,
918918
*,
919-
fee_info: bool = True,
919+
fee_info: bool | None = None,
920920
fee_schedule: bool | None = None,
921921
extra_params: dict | None = None,
922922
) -> dict:
@@ -930,9 +930,9 @@ def get_trade_volume(
930930
:param pair: Asset pair, list of asset pairs or comma delimited list (as
931931
string) of asset pairs to filter
932932
:type pair: str | list[str], optional
933-
:param fee_info: Deprecated and without effect (default: ``True``).
933+
:param fee_info: Deprecated and without effect (default: ``None``).
934934
Kraken now derives fee inclusion from ``pair`` alone and treats
935-
this as a legacy no-op parameter. Calling this method emits a
935+
this as a legacy no-op parameter. Passing it emits a
936936
``DeprecationWarning``; the parameter will be removed in a future
937937
release.
938938
:type fee_info: bool, optional
@@ -1004,14 +1004,15 @@ def get_trade_volume(
10041004
}
10051005
10061006
"""
1007-
warnings.warn(
1008-
f"`fee_info={fee_info}` has no effect: Kraken now derives fee"
1009-
" inclusion from `pair` alone, treating `fee_info` as a legacy"
1010-
" no-op parameter. It will be removed in a future release. See"
1011-
" https://docs.kraken.com/api/docs/rest-api/get-trade-volume",
1012-
category=DeprecationWarning,
1013-
stacklevel=3,
1014-
)
1007+
if defined(fee_info):
1008+
warnings.warn(
1009+
f"`fee_info={fee_info}` has no effect: Kraken now derives fee"
1010+
" inclusion from `pair` alone, treating `fee_info` as a legacy"
1011+
" no-op parameter. It will be removed in a future release. See"
1012+
" https://docs.kraken.com/api/docs/rest-api/get-trade-volume",
1013+
category=DeprecationWarning,
1014+
stacklevel=3,
1015+
)
10151016
params: dict = {}
10161017
if defined(pair):
10171018
params["pair"] = pair

0 commit comments

Comments
 (0)