Skip to content

Only warn on explicit get_trade_volume fee_info use #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btschwertfeger merged 2 commits into from
Sep 27, 2026
Merged

Only warn on explicit get_trade_volume fee_info use #463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76db263
Only warn on explicit get_trade_volume fee_info use
btschwertfeger Sep 27, 2026
083e426
Drop unit tests for get_trade_volume fee_info warning
btschwertfeger Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/kraken/spot/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ def get_trade_volume(
self: User,
pair: str | list[str] | None = None,
*,
fee_info: bool = True,
fee_info: bool | None = None,
fee_schedule: bool | None = None,
extra_params: dict | None = None,
) -> dict:
Expand All @@ -930,9 +930,9 @@ def get_trade_volume(
:param pair: Asset pair, list of asset pairs or comma delimited list (as
string) of asset pairs to filter
:type pair: str | list[str], optional
:param fee_info: Deprecated and without effect (default: ``True``).
:param fee_info: Deprecated and without effect (default: ``None``).
Kraken now derives fee inclusion from ``pair`` alone and treats
this as a legacy no-op parameter. Calling this method emits a
this as a legacy no-op parameter. Passing it emits a
``DeprecationWarning``; the parameter will be removed in a future
release.
:type fee_info: bool, optional
Expand Down Expand Up @@ -1004,14 +1004,15 @@ def get_trade_volume(
}

"""
warnings.warn(
f"`fee_info={fee_info}` has no effect: Kraken now derives fee"
" inclusion from `pair` alone, treating `fee_info` as a legacy"
" no-op parameter. It will be removed in a future release. See"
" https://docs.kraken.com/api/docs/rest-api/get-trade-volume",
category=DeprecationWarning,
stacklevel=3,
)
if defined(fee_info):
warnings.warn(
f"`fee_info={fee_info}` has no effect: Kraken now derives fee"
" inclusion from `pair` alone, treating `fee_info` as a legacy"
" no-op parameter. It will be removed in a future release. See"
" https://docs.kraken.com/api/docs/rest-api/get-trade-volume",
category=DeprecationWarning,
stacklevel=3,
)
params: dict = {}
if defined(pair):
params["pair"] = pair
Expand Down
Loading