Skip to content

Fix trigger_ordertypes allowlist in spot.Trade.create_order - #465

Merged
btschwertfeger merged 2 commits into
masterfrom
fix-trigger-ordertypes-allowlist
Sep 27, 2026
Merged

btschwertfeger merged 2 commits into
masterfrom
fix-trigger-ordertypes-allowlist

Conversation

@btschwertfeger

@btschwertfeger btschwertfeger commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Updating the Spot Trade client's create_order function to accurately map to what the Kraken Docs outline.

Also dropping the claude.md since claude already knows about AGENTS.md.

@btschwertfeger btschwertfeger added Bug Something isn't working Spot Topic related to Spot trading labels Sep 27, 2026
@btschwertfeger btschwertfeger self-assigned this Sep 27, 2026
@btschwertfeger btschwertfeger added this to the Upcoming Release milestone Sep 27, 2026
@btschwertfeger btschwertfeger changed the title Fix trigger_ordertypes allowlist in create_order Fix trigger_ordertypes allowlist in spot.Trade.create_order Sep 27, 2026
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.42%. Comparing base (8b4b0df) to head (31f844e).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files          23       23           
  Lines        2022     2022           
=======================================
  Hits         1707     1707           
  Misses        315      315           
Flag Coverage Δ
futures-private 52.02% <0.00%> (ø)
futures-public 51.92% <0.00%> (ø)
spot-private 60.53% <100.00%> (+0.27%) ⬆️
spot-public 58.16% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/kraken/spot/trade.py 93.61% <100.00%> (ø)

@btschwertfeger
btschwertfeger enabled auto-merge (squash) September 27, 2026 10:30
@btschwertfeger
btschwertfeger merged commit fc6f18d into master Sep 27, 2026
23 checks passed
@btschwertfeger
btschwertfeger deleted the fix-trigger-ordertypes-allowlist branch September 27, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Spot Topic related to Spot trading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant