test(api): fix flaky GetEvaluations tests caused by CreatedAt

The GetEvaluations tests compared the whole response including CreatedAt,
which is generated at request time, so the assertion failed occasionally.

Add normalizeUserEvaluationsCreatedAt to assert CreatedAt is roughly the
current time, then align the expected value so the equality check stays
stable.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: s35560

pkg/api/api/api_grpc_test.go

@@ -2359,6 +2359,9 @@ func TestGrpcGetEvaluationsValidation(t *testing.T) {
 				"authorization": []string{"test-key"},
 			})
 			actual, err := gs.GetEvaluations(ctx, p.input)
+			if p.expected != nil && actual != nil {
+				normalizeUserEvaluationsCreatedAt(t, p.expected.Evaluations, actual.Evaluations, "%s", p.desc)
+			}
 			assert.Equal(t, p.expected, actual, "%s", p.desc)
 			assert.Equal(t, p.expectedErr, err, "%s", p.desc)
 		})
@@ -2410,6 +2413,7 @@ func TestGrpcGetEvaluationsZeroFeature(t *testing.T) {
 			"authorization": []string{"test-key"},
 		})
 		actual, err := gs.GetEvaluations(ctx, p.input)
+		normalizeUserEvaluationsCreatedAt(t, p.expected.Evaluations, actual.Evaluations, "%s", p.desc)
 		assert.Equal(t, p.expected, actual, "%s", p.desc)
 		assert.Equal(t, p.expected.State, actual.State, "%s", p.desc)
 		assert.Equal(t, p.expectedErr, err, "%s", p.desc)
@@ -4959,6 +4963,20 @@ func emptyUserEvaluations(t *testing.T) *featureproto.UserEvaluations {
 	}
 }
 
+// normalizeUserEvaluationsCreatedAt asserts CreatedAt is roughly now, then aligns expected so Equal stays stable.
+func normalizeUserEvaluationsCreatedAt(
+	t *testing.T,
+	expected, actual *featureproto.UserEvaluations,
+	msgAndArgs ...interface{},
+) {
+	t.Helper()
+	if expected == nil || actual == nil {
+		return
+	}
+	assert.InDelta(t, time.Now().Unix(), actual.CreatedAt, 5, msgAndArgs...)
+	expected.CreatedAt = actual.CreatedAt
+}
+
 func TestGrpcListFeatures(t *testing.T) {
 	t.Parallel()
 	mockController := gomock.NewController(t)

pkg/api/api/api_test.go

@@ -716,7 +716,7 @@ func TestGetEvaluationsValidation(t *testing.T) {
 		decoded := decodeSuccessResponse(t, actual.Body)
 		err := json.Unmarshal(decoded, &respBody)
 		assert.NoError(t, err)
-		// FIXME: This is a flaky test. CreateAt may not be equal ocasionally.
+		normalizeUserEvaluationsCreatedAt(t, p.expected.Evaluations, respBody.Evaluations, "%s", p.desc)
 		assert.Equal(t, p.expected, &respBody, "%s", p.desc)
 	}
 }
@@ -779,6 +779,7 @@ func TestGetEvaluationsZeroFeature(t *testing.T) {
 		decoded := decodeSuccessResponse(t, actual.Body)
 		err := json.Unmarshal(decoded, &respBody)
 		assert.NoError(t, err)
+		normalizeUserEvaluationsCreatedAt(t, p.expected.Evaluations, respBody.Evaluations, "%s", p.desc)
 		assert.Equal(t, p.expected, &respBody, "%s", p.desc)
 	}
 }