refactor(notification): switch delete admin notification to soft delete

- Add a deleted flag to the notification table (MySQL + Postgres
  migrations); localizations and read markers stay intact on delete
- DeleteAdminNotification now flags the row and records who deleted it
  and when via last_edited_by/updated_at
- Exclude soft-deleted rows from get, update, and draft listing queries

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: hvn2k1

api-description/web-api.swagger.yaml

@@ -1230,7 +1230,7 @@ paths:
   /v1/admin_notification:
     delete:
       summary: Delete
-      description: Delete a notification along with its read markers. System admin only.
+      description: Soft-delete a notification; it disappears from all listings but its data is retained. System admin only.
       operationId: web.v1.notification.admin.delete
       responses:
         "200":

migration/mysql/20260728000000_add_notification_deleted.sql

@@ -0,0 +1,4 @@
+-- Soft-delete support for the notification center: deleted notifications are
+-- flagged instead of removed so their localizations and read markers stay
+-- intact until the admin audit log is implemented.
+ALTER TABLE notification ADD COLUMN deleted BOOL NOT NULL DEFAULT 0;

migration/mysql/atlas.sum

@@ -1,4 +1,4 @@
-h1:lZ6N6pD7g4R1o3ey4lmh5oCyVrOxGtwVjen4h+WqiZo=
+h1:8YDpIU578LqzbUEvkNKDitZCF1LqIotUqMUsDTn5g08=
 20240626022133_initialization.sql h1:reSmqMhqnsrdIdPU2ezv/PXSL0COlRFX4gQA4U3/wMo=
 20240708065726_update_audit_log_table.sql h1:fi8Xxw4WfSlHDyvq2Ni/8JUiZW8z/0qWWyWm6jFdUy8=
 20240815043128_update_auto_ops_rule_table.sql h1:IKSW9W/XO6SWAYl5WPLJSg6KdsfcZ3rfQhIrf7aOnYc=
@@ -42,3 +42,4 @@ h1:lZ6N6pD7g4R1o3ey4lmh5oCyVrOxGtwVjen4h+WqiZo=
 20260316000000_update_auto_archive_default_days.sql h1:pq20H9ieN5314aAbM9JH29xvFPjj93xoUSmluEZICxw=
 20260514000000_update_feature_variation_value_schema.sql h1:ocGacenoNr4+sVeCeWASFDnUn+Sn2n04XmZpSf+82qM=
 20260713000000_create_notification_tables.sql h1:87SKJUcoNMMv48953z5QyaS9c/AxzJamnf+SZ6/SMJU=
+20260728000000_add_notification_deleted.sql h1:yky/5yXtjVf4Vl9si/FJ5ODUSPzjC1NfUsyfLCTh97I=

migration/postgres/20260728000000_add_notification_deleted.sql

@@ -0,0 +1,4 @@
+-- Soft-delete support for the notification center: deleted notifications are
+-- flagged instead of removed so their localizations and read markers stay
+-- intact until the admin audit log is implemented.
+ALTER TABLE notification ADD COLUMN deleted BOOLEAN NOT NULL DEFAULT FALSE;

migration/postgres/atlas.sum

@@ -1,4 +1,5 @@
-h1:A4Op2+FtS//RFAl45dYO66IFvB9Pcad7eGv/Nn1BoDg=
+h1:s6kmbtFcVifKk1JOyBlaUyVfQtEFuVNgbbGIlTM7A10=
 20260226174000_initialization.sql h1:orWPjklxeOP046jFps+1UhJDdaSDPwDjlODiSe/479c=
 20260514000000_update_feature_variation_value_schema.sql h1:Jp91HETgQvAvqNGTgSBip8ipx3aAI5C4Tsa2z8eplB4=
 20260713000000_create_notification_tables.sql h1:TqsueyglKP41Towy2FsYTGyxI3+h4bRbpGS4MZLLNhw=
+20260728000000_add_notification_deleted.sql h1:OqtTB/u1YAJXjuhwfCJjfTfuNuaLtSvbUvbXD/82L6E=

pkg/notification/api/api.go

@@ -19,6 +19,7 @@ import (
 	"errors"
 	"strconv"
 	"strings"
+	"time"
 
 	"go.uber.org/zap"
 	"google.golang.org/grpc"
@@ -327,15 +328,15 @@ func (s *NotificationService) DeleteAdminNotification(
 	ctx context.Context,
 	req *proto.DeleteAdminNotificationRequest,
 ) (*proto.DeleteAdminNotificationResponse, error) {
-	_, err := s.checkSystemAdminRole(ctx)
+	editor, err := s.checkSystemAdminRole(ctx)
 	if err != nil {
 		return nil, err
 	}
 	if len(strings.TrimSpace(req.Id)) == 0 {
 		return nil, statusNotificationIDRequired.Err()
 	}
 	err = s.dbClient.RunInTransactionV2(ctx, func(ctxWithTx context.Context) error {
-		return s.notificationStorage.DeleteAdminNotification(ctxWithTx, req.Id)
+		return s.notificationStorage.DeleteAdminNotification(ctxWithTx, req.Id, editor.Email, time.Now().Unix())
 	})
 	if err != nil {
 		if errors.Is(err, storage.ErrNotificationNotFound) {

pkg/notification/api/api_test.go

@@ -639,7 +639,7 @@ func TestNotificationService_DeleteAdminNotification(t *testing.T) {
 					return fn(ctx)
 				})
 				s.notificationStorage.(*notificationstoragemock.MockNotificationStorage).EXPECT().DeleteAdminNotification(
-					gomock.Any(), "notification-id-0",
+					gomock.Any(), "notification-id-0", "email", gomock.Any(),
 				).Return(storage.ErrNotificationNotFound)
 			},
 			req: &proto.DeleteAdminNotificationRequest{
@@ -670,7 +670,7 @@ func TestNotificationService_DeleteAdminNotification(t *testing.T) {
 					return fn(ctx)
 				})
 				s.notificationStorage.(*notificationstoragemock.MockNotificationStorage).EXPECT().DeleteAdminNotification(
-					gomock.Any(), "notification-id-0",
+					gomock.Any(), "notification-id-0", "email", gomock.Any(),
 				).Return(nil)
 			},
 			req: &proto.DeleteAdminNotificationRequest{

pkg/notification/storage/mock/notification.go

@@ -175,11 +175,14 @@ func (s *notificationStorage) UpdateAdminNotification(
 
 func (s *notificationStorage) DeleteAdminNotification(
 	ctx context.Context,
-	id string,
+	id, lastEditedBy string,
+	updatedAt int64,
 ) error {
 	result, err := s.qe.ExecContext(
 		ctx,
 		deleteNotificationSQL,
+		lastEditedBy,
+		updatedAt,
 		id,
 	)
 	if err != nil {
@@ -225,6 +228,11 @@ func listDraftAdminNotificationsFilters(
 			Operator: mysqlstorage.OperatorEqual,
 			Value:    int32(proto.Notification_DRAFT),
 		},
+		{
+			Column:   "notification.deleted",
+			Operator: mysqlstorage.OperatorEqual,
+			Value:    false,
+		},
 	}
 	var searchQuery *mysqlstorage.SearchQuery
 	if searchKeyword != "" {

pkg/notification/storage/mysql/notification.go

@@ -606,6 +606,8 @@ func TestDeleteAdminNotification(t *testing.T) {
 				s.qe.(*mock.MockQueryExecer).EXPECT().ExecContext(
 					gomock.Any(),
 					deleteNotificationSQL,
+					"editor@example.com",
+					int64(5),
 					"notification-id-0",
 				).Return(result, nil)
 			},
@@ -619,7 +621,7 @@ func TestDeleteAdminNotification(t *testing.T) {
 			if p.setup != nil {
 				p.setup(storage)
 			}
-			err := storage.DeleteAdminNotification(context.Background(), p.id)
+			err := storage.DeleteAdminNotification(context.Background(), p.id, "editor@example.com", 5)
 			assert.Equal(t, p.expectedErr, err)
 		})
 	}