fix: admin access only entities are not listing for owner users - #2020
Merged
Conversation
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses access control issues for organization owner users who were incorrectly being restricted from viewing entities that should be accessible to them as admin-level users. The changes ensure that organization owners have the same access privileges as organization admins.
- Modified role-based access control logic to properly handle organization owner permissions
- Fixed environment filtering logic across multiple services to include owner users alongside admin users
- Corrected account creation flow to handle existing account updates without duplicate event publishing
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/tag/api/api.go | Updated environment filtering to grant owners same access as admins |
| pkg/push/api/api.go | Updated environment filtering to grant owners same access as admins |
| pkg/notification/api/subscription.go | Updated environment filtering with improved comment clarity |
| pkg/account/domain/account.go | Extended admin role check to include organization owners |
| pkg/account/api/api_key.go | Updated environment filtering to grant owners same access as admins |
| pkg/account/api/admin_account.go | Extended admin privilege checks to include organization owners |
| pkg/account/api/account_test.go | Removed duplicate publisher mock expectation |
| pkg/account/api/account.go | Fixed event publishing flow and extended admin checks to include owners |
cre8ivejp
force-pushed
the
fix-create-account
branch
from
July 23, 2025 14:57
2946bb6 to
eef18cd
Compare
cre8ivejp
force-pushed
the
fix-create-account
branch
from
July 23, 2025 15:00
eef18cd to
52828dc
Compare
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
cre8ivejp
force-pushed
the
fix-create-account
branch
from
July 23, 2025 15:02
52828dc to
358bd1b
Compare
cre8ivejp
marked this pull request as ready for review
July 24, 2025 01:47
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
cre8ivejp
force-pushed
the
fix-create-account
branch
from
July 24, 2025 03:48
df18ec8 to
a82362e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2023 #2024 #2025
Things done