refactor: api error handling in Team and CodeRef packages - #2109
Merged
Conversation
kakcy
changed the title
hvn2k1
reviewed
Sep 9, 2025
| "fmt" | ||
|
|
||
| "github.com/bucketeer-io/bucketeer/pkg/coderef/domain" | ||
| err "github.com/bucketeer-io/bucketeer/pkg/error" |
Contributor
There was a problem hiding this comment.
We usually use "err" for error variable, so for package name, can we use err2 or error2/errors2 ... ?
Contributor
Author
There was a problem hiding this comment.
Thank you for your suggestion.
Renaming a package is expensive, so how about modifying it to bkterr "github.com/bucketeer-io/bucketeer/pkg/error"?
bkt is the prefix for Bucketeer.
Contributor
Author
Contributor
Author
Contributor
There was a problem hiding this comment.
Sorry for the late reply 🙇🏻 , the bkterr lgtm
# Conflicts: # pkg/error/error.go
# Conflicts: # pkg/error/error.go
# Conflicts: # pkg/error/error.go
# Conflicts: # pkg/team/api/api.go
# Conflicts: # pkg/coderef/api/api.go # pkg/coderef/api/code_reference.go # pkg/coderef/storage/code_reference.go # pkg/team/api/api.go # pkg/team/storage/team.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors error handling and status construction throughout the
coderefandteamservices to use a standardized error package. This improves consistency, maintainability, and clarity of gRPC error responses, while also removing legacy error definitions. The changes affect API service files, domain error definitions, and storage error handling.I have also standardized the process of assigning ErrorInfo to GRPCStatus for each error via api.NewGRPCStatus.
This ErrorInfo will be used when moving i18n to the frontend(#1253), and we plan to generate error messages etc. based on this information on the frontend.