refactor: api error handling in AuditLog and AutoOps packages - #2116
Merged
Conversation
kakcy
marked this pull request as draft
September 10, 2025 01:29
kakcy
marked this pull request as ready for review
September 10, 2025 06:48
nnnkkk7
reviewed
Sep 11, 2025
| s.experimentClient.(*experimentclientmock.MockClient).EXPECT().GetGoal( | ||
| gomock.Any(), gomock.Any(), | ||
| ).Return(nil, errors.New("error")) | ||
| ).Return(nil, err.NewErrorInternal("autoops", "error")) |
Contributor
There was a problem hiding this comment.
It'd be better to use pkgErr.AutoopsPackageName.
# Conflicts: # pkg/error/error.go
# Conflicts: # pkg/error/error.go
Contributor
Author
# Conflicts: # pkg/error/error.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors error handling across the audit log and auto ops services to use a centralized error and gRPC status construction mechanism. The changes improve consistency, maintainability, and extensibility of error handling, and introduce support for additional gRPC error codes.
I have also standardized the process of assigning ErrorInfo to GRPCStatus for each error via api.NewGRPCStatus.
This ErrorInfo will be used when moving i18n to the frontend(#1253), and we plan to generate error messages etc. based on this information on the frontend.